Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tuple struct constructors #3856

Closed
wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

r? @brson

@brson
Copy link
Contributor

brson commented Oct 25, 2012

r+

@catamorphism
Copy link
Contributor

r+ on the second commit.

@pcwalton
Copy link
Contributor Author

617c021 r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@pcwalton the trans code looks fine, but I believe the exhaustiveness checking is wrong. You should add some tests for that too--- in particular for cases involving subpatterns that appear in the fields, since I believe something is fishy with the changes you made in that area.

@brson
Copy link
Contributor

brson commented Oct 26, 2012

Is this merged?

@pcwalton pcwalton closed this Oct 27, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this pull request May 15, 2021
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Sep 8, 2024
Enable native libraries on macOS

Fixes rust-lang#3595 by using `-fvisibility=hidden` and the visibility attribute supported by both gcc and clang rather than the previous gcc-only mechanism for symbol hiding. Also brings over cfg changes from rust-lang#3594 which enable native-lib functionality on all unixes.

Thanks for taking a look, feedback very welcome!

cc `@RalfJung`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants