Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run rustfmt on astconv.rs file #38567

Closed
wants to merge 1 commit into from
Closed

run rustfmt on astconv.rs file #38567

wants to merge 1 commit into from

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

//! So this function is used when we're dealing with a sum type to
//! convert the LHS. It only accepts a type that refers to a trait
//! name, and reports an error otherwise.
//!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I guess the trailing blank //! is a feature, not a bug, of rustfmt (since IIUC it refuses to revise the layout of comments in terms of line breaks ... though I had thought @nrc had said something about it being willing to remove some blank lines in certain cases...)

@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 26, 2016

📌 Commit f8db005 has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Dec 26, 2016

☔ The latest upstream changes (presumably #38154) made this pull request unmergeable. Please resolve the merge conflicts.

@srinivasreddy
Copy link
Contributor Author

@pnkfelix merge conflicts resolved. Please approve again.

@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 28, 2016

📌 Commit a6d2929 has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Dec 28, 2016

☔ The latest upstream changes (presumably #38449) made this pull request unmergeable. Please resolve the merge conflicts.

@srinivasreddy
Copy link
Contributor Author

gosh!! @pnkfelix Please rollup again.

@bors
Copy link
Contributor

bors commented Jan 17, 2017

☔ The latest upstream changes (presumably #39110) made this pull request unmergeable. Please resolve the merge conflicts.

PR #38842 has exposed that we were missing the src/test/compile-fail-fulldeps
directory in the search for feature gate tests. Because the detection didn't
work despite the effort to name the test appropriately and add a correct
"// gate-test-proc_macro" comment, proc_macro was added to the whitelist.

We fix this little weakness in the feature gate tidy check and add
the src/test/compile-fail-fulldeps directory to the checked directories.
@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants