Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that the link target ignores the given name #38840

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Warn that the link target ignores the given name #38840

merged 2 commits into from
Jan 9, 2017

Conversation

kjaleshire
Copy link
Contributor

Hi, new contributor here. This is my stab at #20130, any feedback welcome!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the correct change, I think the error message could be improved a little. Thanks for the PR!

requested");
let ofile = if unnamed_output_types > 1 &&
sess.opts.output_types.contains_key(&OutputType::Exe) {
sess.warn("ignoring output name requested with -o for \"link\" output because \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could change the error message less - in particular, keeping filename rather than name seems more informative, and I don't think mentioning -o is necessary. Nit: I would prefer using single quotes or backticks rather than double quotes around link.

Copy link
Contributor Author

@kjaleshire kjaleshire Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I just copied the message suggested in the issue comments.

@nrc
Copy link
Member

nrc commented Jan 9, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 9, 2017

📌 Commit 4af830a has been approved by nrc

@bors
Copy link
Contributor

bors commented Jan 9, 2017

⌛ Testing commit 4af830a with merge f5cfe83...

bors added a commit that referenced this pull request Jan 9, 2017
Warn that the link target ignores the given name

Hi, new contributor here. This is my stab at #20130, any feedback welcome!
@bors
Copy link
Contributor

bors commented Jan 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing f5cfe83 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants