-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only consider value items when searching for methods, not types #39019
Conversation
Fixes #38145 as well |
@bors r+ |
📌 Commit 8848c38 has been approved by |
@bors r- Travis...seems unhappy. I'll investigate. |
@nikomatsakis Time is getting short to backport this. |
@brson let's see if travis is happy, but I think it's fixed now |
So for some reason this particular example, now that it doesn't ICE, triggers an odd path where we try to cite some code from libstd:
(See the snippet for candidate #1) I don't quite follow what's happening there, but it seems like a pre-existing bug? |
@bors r=eddyb p=1
|
📌 Commit d82d4b6 has been approved by |
Accepting for beta backport (tiny patch, regression). cc @rust-lang/compiler |
☀️ Test successful - status-appveyor, status-travis |
Fixes #38919
r? @eddyb