-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update path remapping #39130
Update path remapping #39130
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
- allow arbitrary numbers of remappings - if we're remapping an absolute path, make the remappings absolute
Thanks for the PR! This looks like a step in the right direction (multiple remappings, better handling of relative paths) but here are some things to note:
I'll try to make some progress clarifying the actual logic in the original issue (#38322) soonish. |
@michaelwoerister Thanks - the main reason for posting this is to try and kick things along a bit. This is an issue I've started running into, so I'd like to see it resolved. |
☔ The latest upstream changes (presumably #39563) made this pull request unmergeable. Please resolve the merge conflicts. |
Superseded by #41419 |
This is an update of PR #38348 to fix issue #38322. It allows arbitrary numbers of mappings, and attempts to handle relative remap paths to work as expected on relative source paths.