Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename manifest_version to manifest-version #39630

Merged
merged 1 commit into from
Feb 8, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/tools/build-manifest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
extern crate toml;
extern crate rustc_serialize;

use std::collections::HashMap;
use std::collections::{BTreeMap, HashMap};
use std::env;
use std::fs::File;
use std::io::{self, Read, Write};
Expand Down Expand Up @@ -95,7 +95,6 @@ static MINGW: &'static [&'static str] = &[
"x86_64-pc-windows-gnu",
];

#[derive(RustcEncodable)]
struct Manifest {
manifest_version: String,
date: String,
Expand Down Expand Up @@ -171,8 +170,18 @@ impl Builder {
self.cargo_version = self.version("cargo", "x86_64-unknown-linux-gnu");

self.digest_and_sign();
let manifest = self.build_manifest();
let manifest = toml::encode(&manifest).to_string();
let Manifest { manifest_version, date, pkg } = self.build_manifest();

// Unfortunately we can't use derive(RustcEncodable) here because the
// version field is called `manifest-version`, not `manifest_version`.
// In lieu of that just create the table directly here with a `BTreeMap`
// and wrap it up in a `Value::Table`.
let mut manifest = BTreeMap::new();
manifest.insert("manifest-version".to_string(),
toml::encode(&manifest_version));
manifest.insert("date".to_string(), toml::encode(&date));
manifest.insert("pkg".to_string(), toml::encode(&pkg));
let manifest = toml::Value::Table(manifest).to_string();

let filename = format!("channel-rust-{}.toml", self.channel);
self.write_manifest(&manifest, &filename);
Expand Down