Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #39661 #39662

Merged
merged 2 commits into from
Feb 12, 2017
Merged

Fixes #39661 #39662

merged 2 commits into from
Feb 12, 2017

Conversation

Henning-K
Copy link
Contributor

Clarifies the potential ambiguity.

@Henning-K
Fixed rust-lang#39661
51ef003 
Clarified potential ambiguity.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Looks great! Thank you so much!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 8, 2017

📌 Commit 51ef003 has been approved by steveklabnik

@euclio
Copy link
Contributor

euclio commented Feb 9, 2017

Hm, I think there should be an article before "map".

@Henning-K
Copy link
Contributor Author

@euclio Ah, missed that. How about "a"?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 9, 2017
@frewsxcv
Rollup merge of rust-lang#39662 - Henning-K:patch-1, r=steveklabnik
14d894f 
Fixes rust-lang#39661

Clarifies the potential ambiguity.
@frewsxcv frewsxcv mentioned this pull request Feb 9, 2017
Closed
@frewsxcv
Copy link
Member

Looks good, thanks for your contribution!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2017

📌 Commit 8251a2d has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 12, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39662 - Henning-K:patch-1, r=frewsxcv
747b9e5 
Fixes rust-lang#39661

Clarifies the potential ambiguity.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 12, 2017
Merged
bors added a commit that referenced this pull request Feb 12, 2017
@bors
Auto merge of #39769 - GuillaumeGomez:rollup, r=GuillaumeGomez
81bd267 
Rollup of 7 pull requests

- Successful merges: #39654, #39662, #39697, #39740, #39743, #39756, #39760
- Failed merges:
@bors bors merged commit 8251a2d into rust-lang:master Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BurntSushi BurntSushi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Henning-K @rust-highfive @steveklabnik @bors @euclio @frewsxcv @BurntSushi