Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove wrong packed struct test #39692

Merged
merged 2 commits into from
Feb 11, 2017
Merged

remove wrong packed struct test #39692

merged 2 commits into from
Feb 11, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 9, 2017

This UB was found by running the test under Miri which rejects these unsafe unaligned loads. 😄

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 10, 2017

Oy! Good catch :-)

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 10, 2017

📌 Commit c7f9811 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 10, 2017
@frewsxcv
Rollup merge of rust-lang#39692 - oli-obk:patch-2, r=aturon
8ff98aa 
remove wrong packed struct test

This UB was found by running the test under [Miri](https://github.com/solson/miri) which rejects these unsafe unaligned loads. 😄
@frewsxcv frewsxcv mentioned this pull request Feb 10, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 11, 2017
@frewsxcv
Rollup merge of rust-lang#39692 - oli-obk:patch-2, r=aturon
608be0e 
remove wrong packed struct test

This UB was found by running the test under [Miri](https://github.com/solson/miri) which rejects these unsafe unaligned loads. 😄
@frewsxcv frewsxcv mentioned this pull request Feb 11, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 11, 2017
@frewsxcv
Rollup merge of rust-lang#39692 - oli-obk:patch-2, r=aturon
92cf7ae 
remove wrong packed struct test

This UB was found by running the test under [Miri](https://github.com/solson/miri) which rejects these unsafe unaligned loads. 😄
@frewsxcv frewsxcv mentioned this pull request Feb 11, 2017
Merged
bors added a commit that referenced this pull request Feb 11, 2017
@bors
Auto merge of #39736 - frewsxcv:rollup, r=frewsxcv
bae454e 
Rollup of 9 pull requests

- Successful merges: #39174, #39660, #39676, #39692, #39701, #39710, #39721, #39724, #39725
- Failed merges:
@bors bors merged commit c7f9811 into rust-lang:master Feb 11, 2017
@oli-obk oli-obk deleted the patch-2 branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rust-highfive @aturon @bors