Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy: exempt URLs from the line length restriction #39790

Merged
merged 2 commits into from
Feb 15, 2017
Merged

tidy: exempt URLs from the line length restriction #39790

merged 2 commits into from
Feb 15, 2017

Commits on Feb 13, 2017

  1. tidy: exempt URLs from the line length restriction 

    The length of a URL is usually not under our control, and Markdown
provides no way to split a URL in the middle.  Therefore, comment
lines consisting _solely_ of a URL (possibly with a Markdown link
label in front) should be exempt from the line-length restriction.

Inline hyperlink destinations ( `[foo](http://...)` notation ) are
_not_ exempt, because it is my arrogant opinion that long lines of
that type make the source text illegible.

The patch adds dependencies on the `regex` and `lazy_static` crates
to the tidy utility.  This _appears_ to Just Work, but if you would
rather not have that dependency I am willing to provide a hand-written
parser instead.
    @zackw
    zackw committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    5817351 View commit details
    Browse the repository at this point in the history

  2. Replace regex-based parser for URL lines with open-coded one.

    @zackw
    zackw committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    ff4758c View commit details
    Browse the repository at this point in the history