Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made no_stack_check a stable_removed attribute #40110

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Made no_stack_check a stable_removed attribute #40110

merged 2 commits into from
Mar 2, 2017

Conversation

benschreiber
Copy link
Contributor

r? @brson

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Feb 26, 2017

@bors r+ Thanks @benschreiber !

@bors
Copy link
Contributor

bors commented Feb 26, 2017

📌 Commit 9c5e4af has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 26, 2017

⌛ Testing commit 9c5e4af with merge 1046c25...

@bors
Copy link
Contributor

bors commented Feb 26, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Feb 26, 2017 via email

@alexcrichton
Copy link
Member

@bors: r=brson

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: travis: Split Android into dist/test images #40135

@bors
Copy link
Contributor

bors commented Feb 28, 2017

📌 Commit 9c5e4af has been approved by brson

@alexcrichton
Copy link
Member

@bors: retry

@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Feb 28, 2017
@eddyb
Rollup merge of rust-lang#40110 - benschreiber:nostackcheck, r=brson
4fdeeb7 
Made no_stack_check a stable_removed attribute

r? @brson
@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
@bors
Copy link
Contributor

bors commented Feb 28, 2017

⌛ Testing commit 9c5e4af with merge 6f927d0...

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Feb 28, 2017 via email

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
@frewsxcv
Rollup merge of rust-lang#40110 - benschreiber:nostackcheck, r=brson
aef07cd 
Made no_stack_check a stable_removed attribute

r? @brson
@frewsxcv frewsxcv mentioned this pull request Mar 2, 2017
Merged
bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of #40216 - frewsxcv:rollup, r=frewsxcv
c0b7112 
Rollup of 7 pull requests

- Successful merges: #39832, #40104, #40110, #40117, #40129, #40139, #40166
- Failed merges:
@bors bors merged commit 9c5e4af into rust-lang:master Mar 2, 2017
@benschreiber benschreiber deleted the nostackcheck branch March 2, 2017 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benschreiber @rust-highfive @brson @bors @alexcrichton