Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal liblog #40347

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Remove internal liblog #40347

merged 1 commit into from
Mar 26, 2017

Commits on Mar 23, 2017

  1. Remove internal liblog

    This commit deletes the internal liblog in favor of the implementation that
    lives on crates.io. Similarly it's also setting a convention for adding crates
    to the compiler. The main restriction right now is that we want compiler
    implementation details to be unreachable from normal Rust code (e.g. requires a
    feature), and by default everything in the sysroot is reachable via `extern
    crate`.
    
    The proposal here is to require that crates pulled in have these lines in their
    `src/lib.rs`:
    
        #![cfg_attr(rustbuild, feature(staged_api, rustc_private))]
        #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))]
    
    This'll mean that by default they're not using these attributes but when
    compiled as part of the compiler they do a few things:
    
    * Mark themselves as entirely unstable via the `staged_api` feature and the
      `#![unstable]` attribute.
    * Allow usage of other unstable crates via `feature(rustc_private)` which is
      required if the crate relies on any other crates to compile (other than std).
    alexcrichton committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    e341d60 View commit details
    Browse the repository at this point in the history