Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Split the linux-tested-targets builder #40382

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

alexcrichton
Copy link
Member

Travis only gives us 30GB disk space and we don't currently have an option to
increase that. Each musl target generates "hello world" binaries of about 3.5MB
in size, and we're testing two targets in the same image. We have around 3k
run-pass tests and 2 musl targets which works out to around 20GB. That's
dangerously close to the limit and is causing PRs to bounce.

This PR splits up the builder in two, one for x86_64 musl and the other for
i686. Hopefully that'll keep us under the disk limit.

Closes #40359

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Mar 9, 2017

Can't we change compiletest to remove binaries after it runs them?

@alexcrichton
Copy link
Member Author

Heh in theory yes! We can do w/e we like.

I don't think that's a feature we want to add though because I've at least often found it useful to inspect binaries after-the-fact. We've got extra capacity and in general this was just easier to implement.

@brson
Copy link
Contributor

brson commented Mar 9, 2017

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 9, 2017

📌 Commit 7f28d14 has been approved by brson

@alexcrichton
Copy link
Member Author

@bors: p=100000000

@bors
Copy link
Contributor

bors commented Mar 9, 2017

🔒 Merge conflict

@alexcrichton alexcrichton force-pushed the split-tested-targets branch from 7f28d14 to 5a4e60f Compare March 9, 2017 18:26
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Mar 9, 2017

📌 Commit 5a4e60f has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 9, 2017

⌛ Testing commit 5a4e60f with merge 9e9f0a5...

@bors
Copy link
Contributor

bors commented Mar 9, 2017

💔 Test failed - status-travis

Travis only gives us 30GB disk space and we don't currently have an option to
increase that. Each musl target generates "hello world" binaries of about 3.5MB
in size, and we're testing two targets in the same image. We have around 3k
run-pass tests and 2 musl targets which works out to around 20GB. That's
dangerously close to the limit and is causing PRs to bounce.

This PR splits up the builder in two, one for x86_64 musl and the other for
i686. Hopefully that'll keep us under the disk limit.

Closes rust-lang#40359
@alexcrichton alexcrichton force-pushed the split-tested-targets branch from 5a4e60f to f44801c Compare March 9, 2017 19:54
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Mar 9, 2017

📌 Commit f44801c has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 9, 2017

⌛ Testing commit f44801c with merge 29fd7ee...

@bors
Copy link
Contributor

bors commented Mar 9, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member

frewsxcv commented Mar 9, 2017

@bors retry there's not even a mac log here

@bors
Copy link
Contributor

bors commented Mar 9, 2017

⌛ Testing commit f44801c with merge ec87925...

bors added a commit that referenced this pull request Mar 9, 2017
travis: Split the linux-tested-targets builder

Travis only gives us 30GB disk space and we don't currently have an option to
increase that. Each musl target generates "hello world" binaries of about 3.5MB
in size, and we're testing two targets in the same image. We have around 3k
run-pass tests and 2 musl targets which works out to around 20GB. That's
dangerously close to the limit and is causing PRs to bounce.

This PR splits up the builder in two, one for x86_64 musl and the other for
i686. Hopefully that'll keep us under the disk limit.

Closes #40359
@bors
Copy link
Contributor

bors commented Mar 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing ec87925 to master...

@bors bors merged commit f44801c into rust-lang:master Mar 9, 2017
@bors bors mentioned this pull request Mar 9, 2017
@alexcrichton alexcrichton deleted the split-tested-targets branch March 11, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious "no space left on device" exceptions
6 participants