Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OsString::shrink_to_fit. #40410

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Mar 10, 2017

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 10, 2017
@alexcrichton
Copy link
Member

Thanks! Could you file a tracking issue for this and I'll r+?

@clarfonthey clarfonthey force-pushed the os_string_shrink_to_fit branch from 3ab87ae to 83814fd Compare March 10, 2017 17:15
@clarfonthey
Copy link
Contributor Author

Filed and added!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 83814fd has been approved by alexcrichton

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton

OsString::shrink_to_fit.

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton

OsString::shrink_to_fit.

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton

OsString::shrink_to_fit.

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…r=alexcrichton

OsString::shrink_to_fit.

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…r=alexcrichton

OsString::shrink_to_fit.

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.
@bors bors merged commit 83814fd into rust-lang:master Mar 11, 2017
@clarfonthey clarfonthey deleted the os_string_shrink_to_fit branch March 11, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants