Rollup of 13 pull requests #40440
Closed
Rollup of 13 pull requests #40440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arielb1
commented
Mar 11, 2017
arielb1
commented
- Successful merges: Better docs of rusty parts of typeck #40146, Add missing example for Display::fmt #40299, Allow lints to check Bodys directly #40315, Disallow subtyping between T and U in T: Unsize<U>. #40319, save-analysis: cope with lack of method data after a type error #40344, Fix missing backtick typo #40345, Improve the LLVM IR we generate for trivial functions, especially #[naked] ones. #40367, Do not bother creating StorageLive for TyNever #40372, Fix UB in repr(packed) tests #40373, emit !align attributes on stores of operand pairs #40385, Update gdbr tests #40400, fix #40294 obligation cause.body_id is not always a NodeExpr #40404, rustc: Whitelist the FMA target feature #40431
- Failed merges:
Fixes rendering of the end of the `Configure and Make` section.
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
gdb will now reliably detect the lanugage as rust even before any code is run.
This commit adds the entry `"fma\0"` to the whitelist for the x86 target. LLVM already supports fma but rustc did not directly. Previously rustc permitted `+fma` in the target-feature argument and enabled the use of FMA instructions, but it did not list it in the configuration and attributes. fixes rust-lang#40406
Better docs of rusty parts of typeck
… r=frewsxcv Add missing example for Display::fmt r? @frewsxcv
Allow lints to check Bodys directly r? @eddyb babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))
…r=nikomatsakis Disallow subtyping between T and U in T: Unsize<U>. Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288. E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes. Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).
save-analysis: cope with lack of method data after a type error Fixes rust-lang#39957 r? @eddyb
Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.
Improve the LLVM IR we generate for trivial functions, especially #[naked] ones. These two small changes fix edef1c/libfringe#68: * Don't emit ZST allocas, such as when returning `()` * Don't emit a branch from LLVM's entry block to MIR's `START_BLOCK` unless needed * That is, if a loop branches back to it, although I'm not sure that's even valid MIR
Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
added 4 commits
March 11, 2017 17:13
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb
rustc: Whitelist the FMA target feature This commit adds the entry `"fma\0"` to the whitelist for the x86 target. LLVM already supports fma but rustc did not directly. Previously rustc permitted `+fma` in the target-feature argument and enabled the use of FMA instructions, but it did not list it in the configuration and attributes. fixes rust-lang#40406
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit effb66c has been approved by |
|
⌛ Testing commit effb66c with merge 9db4d87... |
|
💔 Test failed - status-appveyor |
|
… On Sat, Mar 11, 2017 at 9:50 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2344>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40440 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95K4v4AH195tgwaQ1u5HB79WFl18bks5rksLIgaJpZM4MaOro>
.
|
|
@bors: p=3 |
|
💔 Test failed - status-travis |
|
|
Sure |
|
I'll test that locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.