Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target builds for older macOS #40482

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Target builds for older macOS #40482

merged 1 commit into from
Mar 18, 2017

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Mar 13, 2017

Fix #40481

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton alexcrichton reopened this Mar 13, 2017
@alexcrichton
Copy link
Member

Is... travis not listening?

@wagenet
Copy link
Contributor Author

wagenet commented Mar 13, 2017

@alexcrichton tried forcing a new commit to see if it picks it up.

@wagenet wagenet closed this Mar 13, 2017
@wagenet wagenet reopened this Mar 13, 2017
@mzji
Copy link

mzji commented Mar 13, 2017

Travis is missing pull requests: status

@wagenet wagenet closed this Mar 13, 2017
@wagenet wagenet reopened this Mar 13, 2017
@wagenet wagenet mentioned this pull request Mar 13, 2017
Closed
@wagenet
Copy link
Contributor Author

wagenet commented Mar 14, 2017

So the tests run fine until they time-out after 3 hours. They're not stuck and are still making progress at this point.

@alexcrichton
Copy link
Member

@wagenet oh right yeah sorry now that I think about it I don't think we've gotten macs-on-PRs working yet (for... reasons unknown).

In any case I think it got past everything just fine that it needed to (bootstrapping the compiler), so I think we're in the clear here for this PR as-is.

So this gets the compiler itself to 10.8 but libstd as well. Would you still like to get libstd to 10.7 in this PR or would you like to save that for a follow-up PR?

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 14, 2017
@alexcrichton
Copy link
Member

I'm also flagging this for a backport to beta as #40481 affects beta

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 01ffac5 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: r-

Oh actually can the ALLOW_PR=1 be removed?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 61d9387 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: p=1

(beta nominated)

@bors
Copy link
Contributor

bors commented Mar 16, 2017

⌛ Testing commit 61d9387 with merge e897fcb...

@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40482 - wagenet:fix-old-macos, r=alexcrichton
39bca2d 
Target builds for older macOS

Fix rust-lang#40481
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40482 - wagenet:fix-old-macos, r=alexcrichton
b5a5ee4 
Target builds for older macOS

Fix rust-lang#40481
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@bors
Copy link
Contributor

bors commented Mar 17, 2017

⌛ Testing commit 61d9387 with merge a7c2247...

@bors
Copy link
Contributor

bors commented Mar 17, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 17, 2017 via email

@alexcrichton alexcrichton mentioned this pull request Mar 17, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40482 - wagenet:fix-old-macos, r=alexcrichton
0644fae 
Target builds for older macOS

Fix rust-lang#40481
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40482 - wagenet:fix-old-macos, r=alexcrichton
6242e2f 
Target builds for older macOS

Fix rust-lang#40481
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40600 - alexcrichton:beta-next, r=alexcrichton
456ca95 
[beta] Backports to beta

This is a backport of the following PRs to beta:

* #40507
* #40482
* #40526
* #40539
* #40538
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40482 - wagenet:fix-old-macos, r=alexcrichton
4b63f47 
Target builds for older macOS

Fix rust-lang#40481
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@bors
Copy link
Contributor

bors commented Mar 18, 2017

⌛ Testing commit 61d9387 with merge 703b246...

bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40482 - wagenet:fix-old-macos, r=alexcrichton
703b246 
Target builds for older macOS

Fix #40481
@bors
Copy link
Contributor

bors commented Mar 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 703b246 to master...

@bors bors merged commit 61d9387 into rust-lang:master Mar 18, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 20, 2017
This was referenced Jul 15, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wagenet @rust-highfive @alexcrichton @mzji @bors