A couple minor improvements for tidy error handling. #40653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tools/tidy/src/bins.rs
Outdated
| @@ -62,7 +62,7 @@ pub fn check(path: &Path, bad: &mut bool) { | |||
| }); | |||
| let path_bytes = rel_path.as_os_str().as_bytes(); | |||
| if output.status.success() && output.stdout.starts_with(path_bytes) { | |||
| println!("binary checked into source: {}", file.display()); | |||
| tidy_error!("binary checked into source: {}", file.display()); | |||
| *bad = true; | |||
There was a problem hiding this comment.
*bad = true should probably a part of tidy_error
|
r=me with @petrochenkov's comment |
|
Going to wait for #40694 to merge. |
|
☔ The latest upstream changes (presumably #40950) made this pull request unmergeable. Please resolve the merge conflicts. |
Otherwise we get the standard Rust panic message alongside "some tidy checks failed" which seems unnecessary.
|
Comments have been addressed. |
frewsxcv
added
A-docs
|
@bors r=alexcrichton |
|
📌 Commit f789d89 has been approved by |
|
⌛ Testing commit f789d89 with merge 6719895... |
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Apr 9, 2017
A couple minor improvements for tidy error handling. None
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.