Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing urls in ptr docs #40703

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Conversation

GuillaumeGomez
Copy link
Member

r? @rust-lang/docs

@@ -255,6 +255,11 @@ mod prim_unit { }
///
/// *[See also the `std::ptr` module](ptr/index.html).*
///
/// [`null`]: ../std/ptr/fn.null.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why go up and then go back into std again? that is why not

ptr/fn.null.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid falling back on core. I had issues in the past with weird linking like this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recall what those issues are? I know there are issues regarding linking things from libcollections because things are reexported, but wasn't aware of issues with core or std.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have too many PRs so I can't find it but it was common when we linked from core to not find the equivalent in core so I used to always target std. Maybe things have changed since then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change cause issues for people who use no_std?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point!

@steveklabnik
Copy link
Member

@bors: r+ rollup

seems good, thanks!

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit 2715101 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
…eklabnik

Add missing urls in ptr docs

r? @rust-lang/docs
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
…eklabnik

Add missing urls in ptr docs

r? @rust-lang/docs
bors added a commit that referenced this pull request Mar 31, 2017
Rollup of 6 pull requests

- Successful merges: #40703, #40728, #40763, #40871, #40935, #40947
- Failed merges:
@bors bors merged commit 2715101 into rust-lang:master Apr 1, 2017
@GuillaumeGomez GuillaumeGomez deleted the pointer-docs branch April 2, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants