-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing urls in ptr docs #40703
Add missing urls in ptr docs #40703
Conversation
@@ -255,6 +255,11 @@ mod prim_unit { } | |||
/// | |||
/// *[See also the `std::ptr` module](ptr/index.html).* | |||
/// | |||
/// [`null`]: ../std/ptr/fn.null.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why go up and then go back into std
again? that is why not
ptr/fn.null.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid falling back on core
. I had issues in the past with weird linking like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you recall what those issues are? I know there are issues regarding linking things from libcollections because things are reexported, but wasn't aware of issues with core or std.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have too many PRs so I can't find it but it was common when we linked from core to not find the equivalent in core so I used to always target std. Maybe things have changed since then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change cause issues for people who use no_std
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point!
@bors: r+ rollup seems good, thanks! |
📌 Commit 2715101 has been approved by |
…eklabnik Add missing urls in ptr docs r? @rust-lang/docs
…eklabnik Add missing urls in ptr docs r? @rust-lang/docs
r? @rust-lang/docs