Checked slicing for strings #40737
Merged
Checked slicing for strings #40737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
What is this magic‽
nagisa
force-pushed
the
safe-slicing-strs
branch
from
a0d0dff
to
99e4c0a
Compare
BurntSushi
added
the
T-libs-api
|
LGTM. Is it worth adding tests? cc @rust-lang/libs |
|
The doctests already test these. |
|
@bors r+ |
|
📌 Commit 53a3692 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 31, 2017
Checked slicing for strings cc #39932
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #39932