Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all unstable features to Unstable Book. #40786

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

frewsxcv
Copy link
Member

Add all unstable features to the Unstable Book, also remove a few that
either no longer exist or were promoted to stable.

These changes were extracted out of
#40694

@frewsxcv
Copy link
Member Author

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

https://travis-ci.org/rust-lang/rust/jobs/214510619#L1351 ....... wat

Add all unstable features to the Unstable Book, also remove a few that
either no longer exist or were promoted to stable.

These changes were extracted out of
rust-lang#40694
@frewsxcv frewsxcv force-pushed the unstable-book-remaining-features branch from 8291735 to 589e01f Compare March 29, 2017 04:12
@frewsxcv
Copy link
Member Author

This should be passing now. The issue was that I was missing a file linked from the SUMMARY.md so mdbook was trying to create it, which caused the readonly error. This should be fixed now.

r? @steveklabnik

@steveklabnik
Copy link
Member

The issue was that I was missing a file linked from the SUMMARY.md so mdbook was trying to create it, which caused the readonly error.

Oh nooo!

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks 😄

@bors
Copy link
Contributor

bors commented Mar 29, 2017

📌 Commit 589e01f has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 29, 2017
…atures, r=steveklabnik

Add all unstable features to Unstable Book.

Add all unstable features to the Unstable Book, also remove a few that
either no longer exist or were promoted to stable.

These changes were extracted out of
rust-lang#40694
bors added a commit that referenced this pull request Mar 29, 2017
Rollup of 5 pull requests

- Successful merges: #40720, #40786, #40841, #40866, #40897
- Failed merges:
@bors bors merged commit 589e01f into rust-lang:master Mar 29, 2017
@frewsxcv frewsxcv deleted the unstable-book-remaining-features branch March 30, 2017 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants