Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Compile OSX releases with Xcode 7 #40967

Merged
merged 1 commit into from
Apr 1, 2017

Conversation

alexcrichton
Copy link
Member

Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX
10.7. We've done this historically and Gecko would like to maintain this
compabitiliby. This commit moves our release builders for OSX to using Xcode 7
which can compile LLVM for 10.7.

The builders running tests continue to use Xcode 8.2, however, because the LLDB
version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue
running LLDB tests we'll stick with Xcode 8.2.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Mar 31, 2017

Please add a comment to one of these explaining why we are pinned to xcode 7 for some builders. Other than that r=me.

@brson brson assigned brson and unassigned aturon Mar 31, 2017
Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX
10.7. We've done this historically and Gecko would like to maintain this
compabitiliby. This commit moves our release builders for OSX to using Xcode 7
which can compile LLVM for 10.7.

The builders running tests continue to use Xcode 8.2, however, because the LLDB
version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue
running LLDB tests we'll stick with Xcode 8.2.
@alexcrichton
Copy link
Member Author

@bors: r=brson p=10

(beta nominated)

@bors
Copy link
Contributor

bors commented Mar 31, 2017

📌 Commit 3076155 has been approved by brson

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 31, 2017
@bors
Copy link
Contributor

bors commented Mar 31, 2017

⌛ Testing commit 3076155 with merge 6110a74...

@bors
Copy link
Contributor

bors commented Mar 31, 2017

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Mar 31, 2017

The failure is kinda strange, during deploy:

Installing deploy dependencies
ERROR:  Could not find a valid gem 'aws-sdk-resources' (= 2.9.1) in any repository
ERROR:  Possible alternatives: aws-sdk-resources

aws-sdk-resources 2.9.1 was apparently released today so maybe this is some outdated cache / mirror?

@alexcrichton
Copy link
Member Author

Ok in that case sounds spurious

@bors: retry

@bors
Copy link
Contributor

bors commented Apr 1, 2017

⌛ Testing commit 3076155 with merge 99c5e8b...

@bors
Copy link
Contributor

bors commented Apr 1, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

alexcrichton commented Apr 1, 2017 via email

@bors
Copy link
Contributor

bors commented Apr 1, 2017

⌛ Testing commit 3076155 with merge 5e122f5...

bors added a commit that referenced this pull request Apr 1, 2017
travis: Compile OSX releases with Xcode 7

Unfortunately what we're using right now, Xcode 8.2, cannot compile LLVM for OSX
10.7. We've done this historically and Gecko would like to maintain this
compabitiliby. This commit moves our release builders for OSX to using Xcode 7
which can compile LLVM for 10.7.

The builders running tests continue to use Xcode 8.2, however, because the LLDB
version with Xcode 7, 350, is blacklisted in running our LLDB tests. To continue
running LLDB tests we'll stick with Xcode 8.2.
@bors
Copy link
Contributor

bors commented Apr 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 5e122f5 to master...

@bors bors merged commit 3076155 into rust-lang:master Apr 1, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 1, 2017
@alexcrichton alexcrichton deleted the old-osx branch April 1, 2017 14:28
bors added a commit that referenced this pull request Apr 1, 2017
Backport PRs to beta

Backport of

* #40967
* #40836
* #40779
* #40888

Also includes a cargo submodule update
@rillian
Copy link
Contributor

rillian commented Apr 3, 2017

Thanks @alexcrichton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants