remove unnecessary tasks #41063
Merged
remove unnecessary tasks #41063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Apr 6, 2017
|
|
||
| pub fn provide(providers: &mut Providers) { | ||
| *providers = Providers { | ||
| borrowck: borrowck, |
There was a problem hiding this comment.
This should be borrowck, (otherwise there's no point in using this style and you can just assign to providers.borrowck).
eddyb
reviewed
Apr 6, 2017
| @@ -51,4 +51,6 @@ mod borrowck; | |||
|
|
|||
| pub mod graphviz; | |||
|
|
|||
| pub use borrowck::provide; | |||
There was a problem hiding this comment.
The nesting of borrowck still bugs me, heh.
eddyb
reviewed
Apr 6, 2017
| @@ -887,6 +887,7 @@ pub fn phase_3_run_analysis_passes<'tcx, F, R>(sess: &'tcx Session, | |||
| let mut local_providers = ty::maps::Providers::default(); | |||
| mir::provide(&mut local_providers); | |||
| rustc_privacy::provide(&mut local_providers); | |||
| borrowck::provide(&mut local_providers); | |||
There was a problem hiding this comment.
Note to self: make a macro to clean this up.
eddyb
approved these changes
Apr 6, 2017
|
@bors r=eddyb |
|
📌 Commit 2e327a6 has been approved by |
|
⌛ Testing commit 2e327a6 with merge d17e83a... |
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Apr 12, 2017
…c-loops, r=eddyb remove unnecessary tasks Remove various unnecessary tasks. All of these are "always execute" tasks that don't do any writes to tracked state (or else an assert would trigger, anyhow). In some cases, they issue lints or errors, but we''ll deal with that -- and anyway side-effects outside of a task don't cause problems for anything that I can see. The one non-trivial refactoring here is the borrowck conversion, which adds the requirement to go from a `DefId` to a `BodyId`. I tried to make a useful helper here. r? @eddyb cc rust-lang#40746 cc @cramertj @michaelwoerister
|
💔 Test failed - status-travis |
bors
added a commit
that referenced
this pull request
Apr 12, 2017
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove various unnecessary tasks. All of these are "always execute" tasks that don't do any writes to tracked state (or else an assert would trigger, anyhow). In some cases, they issue lints or errors, but we''ll deal with that -- and anyway side-effects outside of a task don't cause problems for anything that I can see.
The one non-trivial refactoring here is the borrowck conversion, which adds the requirement to go from a
DefIdto aBodyId. I tried to make a useful helper here.r? @eddyb
cc #40746
cc @cramertj @michaelwoerister