Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T]::rsplit() and rsplit_mut(), #41020 #41065

Merged
merged 2 commits into from
Apr 6, 2017
Merged

[T]::rsplit() and rsplit_mut(), #41020 #41065

merged 2 commits into from
Apr 6, 2017

Conversation

jorendorff
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jorendorff jorendorff mentioned this pull request Apr 4, 2017
Closed
@alexcrichton
Copy link
Member

@bors: r+

Looks great to me, thanks @jorendorff!

@bors
Copy link
Contributor

bors commented Apr 5, 2017

📌 Commit a45fedf has been approved by alexcrichton

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 5, 2017
Rollup merge of rust-lang#41065 - jorendorff:slice-rsplit-41020, r=al…
d8b6109 
…excrichton

[T]::rsplit() and rsplit_mut(), rust-lang#41020
@arielb1 arielb1 mentioned this pull request Apr 5, 2017
Merged
bors added a commit that referenced this pull request Apr 6, 2017
@bors
Auto merge of #41098 - arielb1:rollup, r=arielb1
6cd15a0 
Rollup of 12 pull requests

- Successful merges: #40479, #40561, #40709, #40815, #40909, #40927, #40943, #41015, #41028, #41052, #41054, #41065
- Failed merges:
@bors bors merged commit a45fedf into rust-lang:master Apr 6, 2017
@jorendorff jorendorff deleted the slice-rsplit-41020 branch April 10, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jorendorff @rust-highfive @alexcrichton @bors @sfackler