Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile WASM as WASM instead of asm.js #41303

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Compile WASM as WASM instead of asm.js #41303

merged 1 commit into from
Apr 15, 2017

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Apr 14, 2017

Looks like the LinkerFlavor change introduced in #40018 accidentally uses GCC for the WebAssembly target, causing Rust to never actually pass the post link args to emscripten. This then causes the code to be compiled as asm.js instead of WebAssembly, because the Binaryen tools never run due to the missing linker argument.

Looks like the LinkerFlavor change introduced in rust-lang#40018 accidentally uses GCC for the WebAssembly target, causing Rust to never actually pass the post link args to emscripten. This then causes the code to be compiled as asm.js instead of WebAssembly, because the Binaryen tools never run due to the missing linker argument.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv
Copy link
Member

cc @japaric

@japaric
Copy link
Member

japaric commented Apr 14, 2017

Ugh, sorry about this. Thanks for the fix, @CryZe.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2017

📌 Commit ec27aa9 has been approved by japaric

@japaric japaric assigned japaric and unassigned nikomatsakis Apr 14, 2017
@frewsxcv frewsxcv added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 14, 2017
Compile WASM as WASM instead of asm.js

Looks like the LinkerFlavor change introduced in rust-lang#40018 accidentally uses GCC for the WebAssembly target, causing Rust to never actually pass the post link args to emscripten. This then causes the code to be compiled as asm.js instead of WebAssembly, because the Binaryen tools never run due to the missing linker argument.
bors added a commit that referenced this pull request Apr 14, 2017
Rollup of 4 pull requests

- Successful merges: #40702, #41172, #41249, #41303
- Failed merges:
@bors bors merged commit ec27aa9 into rust-lang:master Apr 15, 2017
@CryZe CryZe deleted the patch-5 branch April 15, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants