Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check privacy of trait items in all contexts #41332

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Check privacy of trait items in all contexts #41332

merged 3 commits into from
Apr 26, 2017

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Apr 16, 2017 •
edited
Loading

Fixes #28514

This is a sufficiently rare scenario and it's currently guarded by private_in_public lint, so it shouldn't be a [breaking-change] in practice.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Apr 16, 2017
@eddyb
Copy link
Member

eddyb commented Apr 16, 2017

The changes LGTM, started a crater run to see if there's any real impact.

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2017
@eddyb
Copy link
Member

eddyb commented Apr 17, 2017

Sadly, Crater now outputs error: TypeError: Cannot call method 'trim' of undefined.
I had a successful run just a couple days ago, not sure what, if anything, changed. cc @brson

@arielb1 arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2017
@eddyb eddyb added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 20, 2017
@eddyb
Copy link
Member

eddyb commented Apr 20, 2017

Paging @brson again, to make sure he sees it when he gets back.

@nagisa
Copy link
Member

nagisa commented Apr 24, 2017

@eddyb Did you try again since?

@brson
Copy link
Contributor

brson commented Apr 24, 2017

I fixed a bug in crater that should make it work again, and started crate builds for commits fef1026 and 4f7ab0e. It should be done in a few hours if nothing else goes wrong.

@brson
Copy link
Contributor

brson commented Apr 25, 2017

https://gist.github.com/anonymous/dc7effc2a956c5eac26a804c75f315f1

@eddyb
Copy link
Member

eddyb commented Apr 25, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2017

📌 Commit 4f7ab0e has been approved by eddyb

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#41332 - petrochenkov:privti, r=eddyb
070c3ba 
Check privacy of trait items in all contexts

Fixes rust-lang#28514

This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit 4f7ab0e with merge c53bc6d...

@bors
Copy link
Contributor

bors commented Apr 25, 2017

💔 Test failed - status-travis

@petrochenkov
Copy link
Contributor Author

Conflict with recently merged #41494, will fix today.

@arielb1
Copy link
Contributor

arielb1 commented Apr 25, 2017

@bors r-

@petrochenkov
Copy link
Contributor Author

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Apr 25, 2017

📌 Commit 4bd417e has been approved by eddyb

@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit 4bd417e with merge a268165...

@bors
Copy link
Contributor

bors commented Apr 25, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 25, 2017 •
edited
Loading

Probably spurious, though odd. Filed #41545 to track this.

@bors retry

 Downloading utf8-ranges v0.1.3
error: unable to get packages from source
Caused by:
  failed to get 200 response from `https://crates.io/api/v1/crates/utf8-ranges/0.1.3/download`, got 500
thread 'main' panicked at 'tests failed for https://github.com/BurntSushi/xsv', src\tools\cargotest\main.rs:78
note: Run with `RUST_BACKTRACE=1` for a backtrace.
command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools\\x86_64-pc-windows-msvc\\release\\cargotest.exe" "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "C:\\projects\\rust\\build\\ct"
expected success, got: exit code: 101

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 25, 2017
Closed
@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit 4bd417e with merge 7e7114f...

bors added a commit that referenced this pull request Apr 25, 2017
@bors
Auto merge of #41332 - petrochenkov:privti, r=eddyb
7e7114f 
Check privacy of trait items in all contexts

Fixes #28514

This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 25, 2017
@bors
Copy link
Contributor

bors commented Apr 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 7e7114f to master...

@bors bors merged commit 4bd417e into rust-lang:master Apr 26, 2017
@bors bors mentioned this pull request Apr 26, 2017
Merged
@petrochenkov petrochenkov deleted the privti branch August 26, 2017 00:15
@petrochenkov petrochenkov mentioned this pull request Nov 18, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of #46083 - petrochenkov:morepriv, r=nikomatsakis
a12706c 
Type privacy polishing

Various preparations before implementing rust-lang/rfcs#2145 containing final minor breaking changes (mostly for unstable code or code using `allow(private_in_public)`).
(Continuation of #42125, #44633 and #41332.)

It would be good to run crater on this.
r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @eddyb @nagisa @brson @bors @arielb1 @Mark-Simulacrum