bootstrap: Don't workaround uname -m on Darwin #41356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no longer manifests on any versions of OSX that I could find.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit 1dbc72b has been approved by |
alexcrichton
added
the
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…xcrichton bootstrap: Don't workaround uname -m on Darwin This no longer manifests on any versions of OSX that I could find. How far back is Rust officially supported? I can try to get copies to test when this behaviour changed. (Fun fact, at a minimum the comment already lies, since the flag is `-m` :))
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…xcrichton bootstrap: Don't workaround uname -m on Darwin This no longer manifests on any versions of OSX that I could find. How far back is Rust officially supported? I can try to get copies to test when this behaviour changed. (Fun fact, at a minimum the comment already lies, since the flag is `-m` :))
This was referenced Apr 18, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…xcrichton bootstrap: Don't workaround uname -m on Darwin This no longer manifests on any versions of OSX that I could find. How far back is Rust officially supported? I can try to get copies to test when this behaviour changed. (Fun fact, at a minimum the comment already lies, since the flag is `-m` :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This no longer manifests on any versions of OSX that I could find.
How far back is Rust officially supported? I can try to get copies to test when this behaviour changed.
(Fun fact, at a minimum the comment already lies, since the flag is
-m:))