Make unsatisfied trait bounds note multiline #41489

estebank · 2017-04-24T01:03:00Z

Make diagnostic note for existing method with unsatisfied trait bounds
multiline for cleaner output.

  = note: the method `count` exists but the following trait bounds were not satisfied:
          `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
          `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`

Before:

  = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`

rust-highfive · 2017-04-24T01:03:05Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2017-04-24T03:24:05Z

r? @jonathandturner

sophiajt · 2017-04-25T19:17:08Z

Hmm, I mean it's a little better, but I'm wishing we could make the error itself clearer. I'm still not 100% sure is going on when I read either of these errors.

estebank · 2017-04-26T17:23:01Z

@jonathandturner I agree. I noticed this output while working #41488, but it was unrelated to the problem at hand so created this quick PR.

arielb1 · 2017-05-02T09:32:30Z

@jonathandturner - I think this PR fell between the chairs. Do you think it's ready for r+ or are there concerns?

sophiajt · 2017-05-03T01:28:56Z

@estebank - can you file a followup issue to further improve this error? With that, I don't mind r+ing this as an incremental improvement. I just don't want to lose that more work needs to happen.

arielb1 · 2017-05-09T09:07:12Z

After thinking about this, this looks like a strict improvement over the current state - but I would like a UI test (r=me modulo that). However, we do need to figure out a better way to represent this error. I'll open up an issue about it.

sophiajt · 2017-05-11T00:42:04Z

Agree with @arielb1 - ui tests here would help us catch regressions.

sophiajt · 2017-05-14T21:23:07Z

Errors look legit. Maybe there are tests that haven't been updated yet?

[01:02:04] thread 'main' panicked at 'Some tests failed', /checkout/src/tools/compiletest/src/main.rs:315
[01:02:04] 
[01:02:04] ---- [ui] ui/mismatched_types/issue-36053-2.rs stdout ----
[01:02:04] 	ui: /checkout/src/test/ui/mismatched_types/issue-36053-2.rs
[01:02:04] normalized stderr:
[01:02:04] error: no method named `count` found for type `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]>` in the current scope
[01:02:04]   --> $DIR/issue-36053-2.rs:17:55
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                                       ^^^^^
[01:02:04]    |
[01:02:04]    = note: the method `count` exists but the following trait bounds were not satisfied:
[01:02:04]            `[closure@$DIR/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
[01:02:04]            `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnMut<(&'r str,)>`, but the trait `for<'r> std::ops::FnMut<(&'r &str,)>` is required
[01:02:04]   --> $DIR/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnMut<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnMut<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnOnce<(&'r str,)>`, but the trait `for<'r> std::ops::FnOnce<(&'r &str,)>` is required
[01:02:04]   --> $DIR/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnOnce<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnOnce<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error: aborting due to 3 previous errors
[01:02:04] 
[01:02:04] 
[01:02:04] 
[01:02:04] expected stderr:
[01:02:04] error: no method named `count` found for type `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]>` in the current scope
[01:02:04]   --> $DIR/issue-36053-2.rs:17:55
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                                       ^^^^^
[01:02:04]    |
[01:02:04]    = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnMut<(&'r str,)>`, but the trait `for<'r> std::ops::FnMut<(&'r &str,)>` is required
[01:02:04]   --> $DIR/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnMut<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnMut<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnOnce<(&'r str,)>`, but the trait `for<'r> std::ops::FnOnce<(&'r &str,)>` is required
[01:02:04]   --> $DIR/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnOnce<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnOnce<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error: aborting due to 3 previous errors
[01:02:04] 
[01:02:04] 
[01:02:04] 
[01:02:04] diff of stderr:
[01:02:04] 
[01:02:04]  error: no method named `count` found for type `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]>` in the current scope
[01:02:04]    --> $DIR/issue-36053-2.rs:17:55
[01:02:04]     |
[01:02:04]  17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]     |                                                       ^^^^^
[01:02:04]     |
[01:02:04] +   = note: the method `count` exists but the following trait bounds were not satisfied:
[01:02:04] +           `[closure@$DIR/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
[01:02:04] +           `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
[01:02:04] -   = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@$DIR/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
[01:02:04]  
[01:02:04]  error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnMut<(&'r str,)>`, but the trait `for<'r> std::ops::FnMut<(&'r &str,)>` is required
[01:02:04]    --> $DIR/issue-36053-2.rs:17:32
[01:02:04]     |
[01:02:04]  17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]     |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnMut<(&'r str,)>`
[01:02:04]     |                                |
[01:02:04]     |                                requires `for<'r> std::ops::FnMut<(&'r &str,)>`
[01:02:04]     |                                expected &str, found str
[01:02:04]  
[01:02:04]  error[E0281]: type mismatch: `[closure@$DIR/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnOnce<(&'r str,)>`, but the trait `for<'r> std::ops::FnOnce<(&'r &str,)>` is required
[01:02:04]    --> $DIR/issue-36053-2.rs:17:32
[01:02:04]     |
[01:02:04]  17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]     |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnOnce<(&'r str,)>`
[01:02:04]     |                                |
[01:02:04]     |                                requires `for<'r> std::ops::FnOnce<(&'r &str,)>`
[01:02:04]     |                                expected &str, found str
[01:02:04]  
[01:02:04]  error: aborting due to 3 previous errors
[01:02:04]  
[01:02:04] 
[01:02:04] The actual stderr differed from the expected stderr.
[01:02:04] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/mismatched_types/issue-36053-2.stderr
[01:02:04] To update references, run this command from build directory:
[01:02:04] /checkout/src/test/ui/update-references.sh '/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui' 'mismatched_types/issue-36053-2.rs'
[01:02:04] 
[01:02:04] error: 1 errors occurred comparing output.
[01:02:04] status: exit code: 101
[01:02:04] command: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /checkout/src/test/ui/mismatched_types/issue-36053-2.rs -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui --target=x86_64-unknown-linux-gnu -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/mismatched_types/issue-36053-2.stage2-x86_64-unknown-linux-gnu.ui.libaux -C prefer-dynamic -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/mismatched_types/issue-36053-2.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers
[01:02:04] stdout:
[01:02:04] ------------------------------------------
[01:02:04] 
[01:02:04] ------------------------------------------
[01:02:04] stderr:
[01:02:04] ------------------------------------------
[01:02:04] error: no method named `count` found for type `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@/checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:39: 17:53]>` in the current scope
[01:02:04]   --> /checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:55
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                                       ^^^^^
[01:02:04]    |
[01:02:04]    = note: the method `count` exists but the following trait bounds were not satisfied:
[01:02:04]            `[closure@/checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
[01:02:04]            `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@/checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@/checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnMut<(&'r str,)>`, but the trait `for<'r> std::ops::FnMut<(&'r &str,)>` is required
[01:02:04]   --> /checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnMut<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnMut<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error[E0281]: type mismatch: `[closure@/checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:39: 17:53]` implements the trait `for<'r> std::ops::FnOnce<(&'r str,)>`, but the trait `for<'r> std::ops::FnOnce<(&'r &str,)>` is required
[01:02:04]   --> /checkout/src/test/ui/mismatched_types/issue-36053-2.rs:17:32
[01:02:04]    |
[01:02:04] 17 |     once::<&str>("str").fuse().filter(|a: &str| true).count();
[01:02:04]    |                                ^^^^^^ -------------- implements `for<'r> std::ops::FnOnce<(&'r str,)>`
[01:02:04]    |                                |
[01:02:04]    |                                requires `for<'r> std::ops::FnOnce<(&'r &str,)>`
[01:02:04]    |                                expected &str, found str
[01:02:04] 
[01:02:04] error: aborting due to 3 previous errors
[01:02:04] 
[01:02:04] 
[01:02:04] ------------------------------------------
[01:02:04] 
[01:02:04] thread '[ui] ui/mismatched_types/issue-36053-2.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2472
[01:02:04] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:02:04] 
[01:02:04] 
[01:02:04] failures:
[01:02:04]     [ui] ui/mismatched_types/issue-36053-2.rs
[01:02:04] 
[01:02:04] test result: FAILED. 274 passed; 1 failed; 1 ignored; 0 measured
[01:02:04]

Make diagnostic note for existing method with unsatisfied trait bounds multiline for cleaner output. ``` = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>` `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator` Before: ``` = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator` ```

arielb1 · 2017-05-15T09:30:21Z

@bors r+ rollup

bors · 2017-05-15T09:30:22Z

📌 Commit c0d5aa8 has been approved by arielb1

…r=arielb1 Make unsatisfied trait bounds note multiline Make diagnostic note for existing method with unsatisfied trait bounds multiline for cleaner output. ``` = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>` `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator` ``` Before: ``` = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator` ```

Rollup of 8 pull requests - Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028 - Failed merges:

rust-highfive assigned eddyb Apr 24, 2017

estebank force-pushed the trait-bounds-diagnosstic branch from 0dfc9b5 to f1203f0 Compare April 24, 2017 01:57

rust-highfive assigned sophiajt and unassigned eddyb Apr 24, 2017

carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2017

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2017

estebank force-pushed the trait-bounds-diagnosstic branch from f1203f0 to cb34de5 Compare May 14, 2017 18:08

estebank force-pushed the trait-bounds-diagnosstic branch from cb34de5 to c0d5aa8 Compare May 15, 2017 03:38

frewsxcv mentioned this pull request May 15, 2017

Rollup of 7 pull requests #42010

Closed

frewsxcv mentioned this pull request May 15, 2017

Rollup of 6 pull requests #42012

Closed

frewsxcv mentioned this pull request May 16, 2017

Rollup of 6 pull requests #42022

Closed

Mark-Simulacrum mentioned this pull request May 16, 2017

Rollup of 8 pull requests #42032

Closed

Mark-Simulacrum mentioned this pull request May 16, 2017

Rollup of 8 pull requests #42038

Merged

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2017

bors added a commit that referenced this pull request May 16, 2017

Auto merge of #42038 - Mark-Simulacrum:rollup, r=Mark-Simulacrum

0f68728

Rollup of 8 pull requests - Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028 - Failed merges:

bors merged commit c0d5aa8 into rust-lang:master May 16, 2017

estebank deleted the trait-bounds-diagnosstic branch November 9, 2023 05:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make unsatisfied trait bounds note multiline #41489

Make unsatisfied trait bounds note multiline #41489

estebank commented Apr 24, 2017

rust-highfive commented Apr 24, 2017

eddyb commented Apr 24, 2017

sophiajt commented Apr 25, 2017

estebank commented Apr 26, 2017

arielb1 commented May 2, 2017

sophiajt commented May 3, 2017

arielb1 commented May 9, 2017

sophiajt commented May 11, 2017

sophiajt commented May 14, 2017

arielb1 commented May 15, 2017

bors commented May 15, 2017

Make unsatisfied trait bounds note multiline #41489

Make unsatisfied trait bounds note multiline #41489

Conversation

estebank commented Apr 24, 2017

rust-highfive commented Apr 24, 2017

eddyb commented Apr 24, 2017

sophiajt commented Apr 25, 2017

estebank commented Apr 26, 2017

arielb1 commented May 2, 2017

sophiajt commented May 3, 2017

arielb1 commented May 9, 2017

sophiajt commented May 11, 2017

sophiajt commented May 14, 2017

arielb1 commented May 15, 2017

bors commented May 15, 2017