Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen herd cows #41506

Closed
wants to merge 2 commits into from
Closed

Gen herd cows #41506

wants to merge 2 commits into from

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Apr 24, 2017

This is an extension of pr: #41449 to experiment with @jmesmon suggestions.

This is mostly to use the ci services. I will close after.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 24, 2017

Wanted to check in with you to make sure you're aware that rustc can be built and tested locally (as well as the standard library). Let us know if there's anything we can help you out with, either in an issue here or on IRC (#rust-infra on irc.mozilla.org is a good place to start with build system problems).

./x.py test src/tools/tidy && ./x.py test src/libtest --stage1 is the command I utilize to test locally, though I don't work on the stdlib most of the time, so not sure that runs those tests. That should help you test PRs more quickly than waiting for the CI, which can be rather slow.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Apr 24, 2017

I appreciate the check in. I should set that up. I was working in a separate pr so that my original one stays mergeable, and so the test failures can be linked to.

@bors
Copy link
Contributor

bors commented Apr 26, 2017

☔ The latest upstream changes (presumably #41258) made this pull request unmergeable. Please resolve the merge conflicts.

@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 26, 2017
@Eh2406
Copy link
Contributor Author

Eh2406 commented Apr 29, 2017

Thanks, for letting me use the ci.

@Eh2406 Eh2406 closed this Apr 29, 2017
@Eh2406 Eh2406 deleted the gen_herd_cows branch April 29, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants