Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change arm-linux-androideabi to correspond to the armeabi official ABI #41656

Merged
merged 1 commit into from
May 3, 2017
Merged

Change arm-linux-androideabi to correspond to the armeabi official ABI #41656

merged 1 commit into from
May 3, 2017

Conversation

malbarbo
Copy link
Contributor

Fixes #40941.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@malbarbo
Copy link
Contributor Author

malbarbo commented Apr 30, 2017 •
edited
Loading

It this the correct fix?

@eddyb
Copy link
Member

eddyb commented Apr 30, 2017

r? @japaric

@rust-highfive rust-highfive assigned japaric and unassigned eddyb Apr 30, 2017
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 2, 2017

Thanks for the PR @malbarbo. @japaric or someone else should be reviewing your PR shortly.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @malbarbo!

FWIW the reason we didn't do this originally was to prevent regressing Servo, but I just chatted with @fabricedesre on IRC and it sounds like they're good to go (can change to armv7 target if necessary).

Also cc @larsbergstrom to make sure you're in the loop on this as well.

@bors
Copy link
Contributor

bors commented May 2, 2017

📌 Commit 5cf0446 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 3, 2017
@frewsxcv
Rollup merge of rust-lang#41656 - malbarbo:android-armeabi, r=alexcri…
c386832 
…chton

Change arm-linux-androideabi to correspond to the armeabi official ABI

Fixes rust-lang#40941.
@frewsxcv frewsxcv mentioned this pull request May 3, 2017
Merged
bors added a commit that referenced this pull request May 3, 2017
@bors
Auto merge of #41717 - frewsxcv:rollup, r=frewsxcv
146dc67 
Rollup of 7 pull requests

- Successful merges: #41217, #41625, #41640, #41653, #41656, #41657, #41705
- Failed merges:
@bors bors merged commit 5cf0446 into rust-lang:master May 3, 2017
@malbarbo
Copy link
Contributor Author

malbarbo commented May 3, 2017

Thanks Alex! Should this be tagged relnotes?

@alexcrichton
Copy link
Member

Indeed yeah

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label May 3, 2017
@larsbergstrom larsbergstrom mentioned this pull request May 3, 2017
Closed
@larsbergstrom
Copy link
Contributor

@alexcrichton Thanks for the heads-up!

@malbarbo malbarbo mentioned this pull request May 3, 2017
Closed
@malbarbo malbarbo mentioned this pull request Jan 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@japaric japaric

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@malbarbo @rust-highfive @eddyb @arielb1 @alexcrichton @bors @larsbergstrom @carols10cents @japaric