-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove need for &format!(...) or &&"" dances in span_label
calls
#41745
Conversation
Thanks! I always had a mental note to do that but then forgot. |
@bors r+ |
📌 Commit b18117a has been approved by |
⌛ Testing commit b18117a with merge 0c85b2b... |
💔 Test failed - status-travis |
Looking at Travis, seems like a few places might have been missed:
|
Nothing missed. It just bitrots very fast since it touches every single span_labelb. Will fix later |
Well, since @jonathandturner already r+ed and you didn't change much, I'll just r+ as well. @bors: r=jonathandturner |
📌 Commit dd87eab has been approved by |
Remove need for &format!(...) or &&"" dances in `span_label` calls These were always a thorn in my eye. Note that this will monomorphize to two impls, one for `String` and one for `&str`. But I think that cost is worth the ergonomics at the call sites that can be seen throughout this PR.
☀️ Test successful - status-appveyor, status-travis |
These were always a thorn in my eye. Note that this will monomorphize to two impls, one for
String
and one for&str
. But I think that cost is worth the ergonomics at the call sites that can be seen throughout this PR.