Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bare CR in ////-style comment. #41827

Merged
merged 1 commit into from
May 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libsyntax/parse/lexer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ impl<'a> StringReader<'a> {
self.bump();

// line comments starting with "///" or "//!" are doc-comments
let doc_comment = self.ch_is('/') || self.ch_is('!');
let doc_comment = (self.ch_is('/') && !self.nextch_is('/')) || self.ch_is('!');
let start_bpos = self.pos - BytePos(2);

while !self.is_eof() {
Expand Down
6 changes: 6 additions & 0 deletions src/test/parse-fail/lex-bare-cr-string-literal-doc-comment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ pub fn bar() {}
//~^^ ERROR: bare CR not allowed in block doc-comment

fn main() {
//! doc comment with bare CR: ''
//~^ ERROR: bare CR not allowed in doc-comment

/*! block doc comment with bare CR: '' */
//~^ ERROR: bare CR not allowed in block doc-comment

// the following string literal has a bare CR in it
let _s = "foobar"; //~ ERROR: bare CR not allowed in string

Expand Down
18 changes: 18 additions & 0 deletions src/test/run-pass/lex-bare-cr-nondoc-comment.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-tidy-cr

// nondoc comment with bare CR: ''
//// nondoc comment with bare CR: ''
/* block nondoc comment with bare CR: '' */

fn main() {
}
Expand Down