Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error management when /proc is not mounted #42056

Merged
merged 1 commit into from
May 19, 2017
Merged

Improve the error management when /proc is not mounted #42056

merged 1 commit into from
May 19, 2017

Conversation

sylvestre
Copy link
Contributor

This PR does two things:

  • Triggers an error on GNU/Linux & Android when /proc/self/exe doesn't exist
  • Handle the error properly

@sylvestre
Improve the error management when /proc is not mounted
1b6a182 
This PR does two things:
* Triggers an error on GNU/Linux & Android when /proc/self/exe doesn't exist
* Handle the error properly
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2017
@aidanhs
Copy link
Member

aidanhs commented May 17, 2017

Thanks for the PR @sylvestre, we'll make sure it gets reviewed by @arielb1 or another reviewer soon!

@arielb1
Copy link
Contributor

arielb1 commented May 18, 2017

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks @sylvestre!

@bors
Copy link
Contributor

bors commented May 18, 2017

📌 Commit 1b6a182 has been approved by alexcrichton

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42056 - sylvestre:master, r=alexcrichton
28050d8 
Improve the error management when /proc is not mounted

This PR does two things:
* Triggers an error on GNU/Linux & Android when /proc/self/exe doesn't exist
* Handle the error properly
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 18, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42056 - sylvestre:master, r=alexcrichton
12c4a99 
Improve the error management when /proc is not mounted

This PR does two things:
* Triggers an error on GNU/Linux & Android when /proc/self/exe doesn't exist
* Handle the error properly
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 18, 2017
Closed
@bors
Copy link
Contributor

bors commented May 19, 2017

⌛ Testing commit 1b6a182 with merge 561a121...

@bors
Copy link
Contributor

bors commented May 19, 2017

💔 Test failed - status-appveyor

@sylvestre
Copy link
Contributor Author

Probably not my fault:

Downloading rustc-serialize v0.3.24
error: unable to get packages from source
To learn more, run the command again with --verbose.
Build completed unsuccessfully in 0:02:28

@alexcrichton
Copy link
Member

@bors: retry

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 19, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42056 - sylvestre:master, r=alexcrichton
0011828 
Improve the error management when /proc is not mounted

This PR does two things:
* Triggers an error on GNU/Linux & Android when /proc/self/exe doesn't exist
* Handle the error properly
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 19, 2017
Merged
bors added a commit that referenced this pull request May 19, 2017
@bors
Auto merge of #42105 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
5dfcd85 
Rollup of 17 pull requests

- Successful merges: #41870, #41910, #41958, #41971, #42006, #42024, #42037, #42056, #42067, #42070, #42079, #42080, #42082, #42089, #42092, #42096, #42100
- Failed merges:
@bors bors merged commit 1b6a182 into rust-lang:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sylvestre @rust-highfive @aidanhs @arielb1 @alexcrichton @bors