-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: "warning: redundant linker flag specified for library ole32
"
#42113
Conversation
llvm-config seems to output this library name correctly now, removing the need for the hack in "librustc_llvm/build.rs".
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Ha, I was mildly annoyed by this message as well, thanks for fixing. |
📌 Commit 2e0043a has been approved by |
⌛ Testing commit 2e0043a with merge f4e4ada... |
💔 Test failed - status-appveyor |
@bors retry We appear to have just failed to compile rustc:
|
Fix: "warning: redundant linker flag specified for library `ole32`" llvm-config seems to output this library name correctly now, removing the need for the hack in "librustc_llvm/build.rs".
☀️ Test successful - status-appveyor, status-travis |
llvm-config seems to output this library name correctly now, removing
the need for the hack in "librustc_llvm/build.rs".