Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "warning: redundant linker flag specified for library ole32" #42113

Merged
merged 1 commit into from
May 20, 2017

Conversation

segevfiner
Copy link
Contributor

llvm-config seems to output this library name correctly now, removing
the need for the hack in "librustc_llvm/build.rs".

llvm-config seems to output this library name correctly now, removing
the need for the hack in "librustc_llvm/build.rs".
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrochenkov
Copy link
Contributor

Ha, I was mildly annoyed by this message as well, thanks for fixing.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2017

📌 Commit 2e0043a has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented May 20, 2017

⌛ Testing commit 2e0043a with merge f4e4ada...

@bors
Copy link
Contributor

bors commented May 20, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

@bors retry

We appear to have just failed to compile rustc:

:36:29]    Compiling rustc v0.0.0 (file:///C:/projects/rust/src/librustc)
[00:40:16] error: Could not compile `rustc`.
[00:40:16]
[00:40:16] To learn more, run the command again with --verbose.
[00:40:16]
[00:40:16]
[00:40:16] command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "build" "-j" "2" "--target" "x86_64-pc-windows-msvc" "--release" "--locked" "--features" "" "--manifest-path" "C:\\projects\\rust\\src/rustc/Cargo.toml"
[00:40:16] expected success, got: exit code: 101
[00:40:16]
[00:40:16]
[00:40:16] Build completed unsuccessfully in 0:17:04
[00:40:16] Command exited with code 1

@bors
Copy link
Contributor

bors commented May 20, 2017

⌛ Testing commit 2e0043a with merge a0da1e0...

bors added a commit that referenced this pull request May 20, 2017
Fix: "warning: redundant linker flag specified for library `ole32`"

llvm-config seems to output this library name correctly now, removing
the need for the hack in "librustc_llvm/build.rs".
@bors
Copy link
Contributor

bors commented May 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing a0da1e0 to master...

@bors bors merged commit 2e0043a into rust-lang:master May 20, 2017
@segevfiner segevfiner deleted the fix-ole32-warning branch May 20, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants