remove "much" from unicode diagnostic #42120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
"X looks much like Y" is not an unusual construct. It emphasizes a strong similarity. |
|
Didn't mean to imply that it's unusual or incorrect. It just sounds a little odd to my ear. I figured that if you can get the same message across in fewer words, why not? |
Mark-Simulacrum
added
the
S-waiting-on-review
|
r? @sfackler |
|
Umm for some reason I was convinced this code was in libstd. But it's in libsyntax. |
|
📌 Commit 9ad0dba has been approved by |
arielb1
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 24, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 24, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
bors
added a commit
that referenced
this pull request
May 24, 2017
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
bors
added a commit
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The English seems slightly awkward to me, and it's unnecessary.