make ui test output patch compatible #41948 #42144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Niko, could you take a look at @cengizio's questions about unit tests? |
carols10cents
added
the
S-waiting-on-review
|
Yeah, I'm not sure what's the best way to handle unit-testing. The most "robust" would be to somehow "execute" the runtest tool and capture the output, but perhaps it'd be easier to just isolate the routines in question and have them read from simulated data structures, writing to a |
|
@bors r+ rollup |
|
📌 Commit 9111d07 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 23, 2017
make ui test output patch compatible rust-lang#41948 Hello! Previously with rust-lang#41474 I've changed the internals of UI test output comparison mechanism. That change didn't change the diff format that we were producing but we needed to improve it anyway. This makes unified diff lines a little bit more `patch` compatible. Also I tried to introduce a unit test to check this but couldn't decide which of the following to implement: 1. Should I replace `println` macros with `Writer`s? And access the produced output within a test? 2. Should I add an external test (something like `src/test/run-pass/command-exec.rs`) 3. There are crates that capture `stdout`. Are they safe to use here? (I don't think so) Thanks! cc @nikomatsakis
bors
added a commit
that referenced
this pull request
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Previously with #41474 I've changed the internals of UI test output comparison mechanism.
That change didn't change the diff format that we were producing but we needed to improve it anyway.
This makes unified diff lines a little bit more
patchcompatible.Also I tried to introduce a unit test to check this but couldn't decide which of the following to implement:
printlnmacros withWriters? And access the produced output within a test?src/test/run-pass/command-exec.rs)stdout. Are they safe to use here? (I don't think so)Thanks!
cc @nikomatsakis