Update rust-installer for Windows executable mode #42343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
|
@bors: r+ |
|
📌 Commit 0fba1f7 has been approved by |
alexcrichton
added
the
S-waiting-on-bors
|
@bors rollup |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 1, 2017
…crichton Update rust-installer for Windows executable mode It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 1, 2017
…crichton Update rust-installer for Windows executable mode It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 2, 2017
…crichton Update rust-installer for Windows executable mode It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 2, 2017
…crichton Update rust-installer for Windows executable mode It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
|
Thanks, @cuviper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now marks a few whitelisted extensions as executable in the tarball,
so Windows packages can be extracted on other platforms and directly
execute install.sh.
It also includes a fix for the chmod on bulk dirs, so now the html docs
won't be marked executable en masse.
Fixes #42121
r? @alexcrichton