Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve panic docs for Instant::duration_since #43256

Merged
merged 1 commit into from
Jul 23, 2017
Merged

Improve panic docs for Instant::duration_since #43256

merged 1 commit into from
Jul 23, 2017

Conversation

Others
Copy link
Contributor

@Others Others commented Jul 15, 2017

The docs for Instant::duration_since has a confusing section on panicking. It's
much more clear without the second two sentences of description.

@Others
Improve panic docs for Instant::duration_since
c458627 
The docs for Instant::duration_since has a confusing section on panicking. It's
much more clear without the second two sentences of description.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

r? @steveklabnik

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2017
@steveklabnik
Copy link
Member

@bors: r+

agreed, thanks!

@bors
Copy link
Contributor

bors commented Jul 18, 2017

📌 Commit c458627 has been approved by steveklabnik

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jul 18, 2017

@bors rollup

@bors
Copy link
Contributor

bors commented Jul 19, 2017

⌛ Testing commit c458627 with merge c57adc276eec266c41e605ad85fbde7198aeab73...

@bors
Copy link
Contributor

bors commented Jul 19, 2017

💔 Test failed - status-appveyor

@nagbot-rs
Copy link

nagbot-rs commented Jul 19, 2017 via email

@bors
Copy link
Contributor

bors commented Jul 19, 2017

@nagbot-rs: 🔑 Insufficient privileges: and not in try users

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit c458627 with merge 5ba271e42032f53fe7f92fa2c091c1e9a736519f...

@bors
Copy link
Contributor

bors commented Jul 21, 2017

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Jul 21, 2017

@bors retry

  • Spurious network failure, that seems to have fixed itself

TimNN added a commit to TimNN/rust that referenced this pull request Jul 21, 2017
@TimNN
Rollup merge of rust-lang#43256 - Others:patch-1, r=steveklabnik
3c6e389 
Improve panic docs for Instant::duration_since

The docs for Instant::duration_since has a confusing section on panicking. It's
much more clear without the second two sentences of description.
@TimNN TimNN mentioned this pull request Jul 21, 2017
Closed
bors added a commit that referenced this pull request Jul 21, 2017
@bors
Auto merge of #43388 - TimNN:rollup, r=TimNN
bf51b85 
Rollup of 8 pull requests

- Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343
- Failed merges:
@bors
Copy link
Contributor

bors commented Jul 23, 2017

⌛ Testing commit c458627 with merge 3cf2c04...

bors added a commit that referenced this pull request Jul 23, 2017
@bors
Auto merge of #43256 - Others:patch-1, r=steveklabnik
3cf2c04 
Improve panic docs for Instant::duration_since

The docs for Instant::duration_since has a confusing section on panicking. It's
much more clear without the second two sentences of description.
@bors
Copy link
Contributor

bors commented Jul 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 3cf2c04 to master...

@bors bors merged commit c458627 into rust-lang:master Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Others @rust-highfive @sfackler @steveklabnik @bors @arielb1 @nagbot-rs @alexcrichton @TimNN @Mark-Simulacrum