Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inline debug methods #43856

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Don't inline debug methods #43856

merged 1 commit into from
Aug 14, 2017

Conversation

sfackler
Copy link
Member

The inner methods aren't inlined, so this puts more pressure on LLVM for
literally no benefit.

Closes #43843

The inner methods aren't inlined, so this puts more pressure on LLVM for
literally no benefit.

Closes rust-lang#43843
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 14, 2017

📌 Commit 81f481d has been approved by alexcrichton

@alexcrichton alexcrichton reopened this Aug 14, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 14, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 14, 2017

📌 Commit 81f481d has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 14, 2017

⌛ Testing commit 81f481d with merge b1ff235...

bors added a commit that referenced this pull request Aug 14, 2017
Don't inline debug methods

The inner methods aren't inlined, so this puts more pressure on LLVM for
literally no benefit.

Closes #43843
@bors
Copy link
Contributor

bors commented Aug 14, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b1ff235 to master...

@bors bors merged commit 81f481d into rust-lang:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants