Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that std::hash::Hasher::finish() does not reset the hasher. #43905

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Document that std::hash::Hasher::finish() does not reset the hasher. #43905

merged 1 commit into from
Aug 17, 2017

Conversation

partim
Copy link
Contributor

@partim partim commented Aug 16, 2017

Clarifies the fact that finish() doesn’t in fact end or reset the hasher. This was surprising to me …

Follows up on and fixes #43763

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@rust-lang/libs I want to make sure this is a feature, not a bug. These docs look good to me, so as long as yinz sign off on it, r=me

@alexcrichton
Copy link
Member

IIRC this was the intention, yes. Thanks for the PR @partim!

@partim
Copy link
Contributor Author

partim commented Aug 16, 2017

As @bluss pointed out in #43763, because of the &self, the method can’t really do anything else.

@steveklabnik
Copy link
Member

@bors: r+ rollup

great, thank you!

@bors
Copy link
Contributor

bors commented Aug 16, 2017

📌 Commit 02aaa11 has been approved by steveklabnik

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2017
@frewsxcv
Rollup merge of rust-lang#43905 - partim:master, r=steveklabnik
1512e44 
Document that `std::hash::Hasher::finish()` does not reset the hasher.

Clarifies the fact that `finish()` doesn’t in fact end or reset the hasher. This was surprising to me …

Follows up on and fixes rust-lang#43763
@frewsxcv frewsxcv mentioned this pull request Aug 17, 2017
Merged
bors added a commit that referenced this pull request Aug 17, 2017
@bors
Auto merge of #43939 - frewsxcv:rollup, r=frewsxcv
59ccba9 
Rollup of 9 pull requests

- Successful merges: #43891, #43905, #43912, #43914, #43915, #43916, #43920, #43928, #43930
- Failed merges:
@bors bors merged commit 02aaa11 into rust-lang:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hasher::finish() does not reset the hasher.
7 participants
@partim @rust-highfive @steveklabnik @alexcrichton @bors @aturon @aidanhs