Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haiku/librustc_back: Remove incorrect no_integrated_as #44091

Merged
merged 1 commit into from
Aug 26, 2017
Merged

haiku/librustc_back: Remove incorrect no_integrated_as #44091

merged 1 commit into from
Aug 26, 2017

Conversation

kallisti5
Copy link
Contributor

  • Makes rust bootstrap incorrectly search for xxx.s vs xxx.0.s
  • Not needed or incorrect fix for another issue.

@kallisti5
haiku/librustc_back: Remove incorrect no_integrated_as
6ca124b 
* Makes rust bootstrap incorrectly search for xxx.s vs xxx.0.s
* Not needed or incorrect fix for another issue.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Aug 25, 2017

Please open an issue about the bug this triggers.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2017

📌 Commit 6ca124b has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Aug 25, 2017

cc @michaelwoerister In case the bug is obvious.

@alexcrichton alexcrichton mentioned this pull request Aug 26, 2017
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 26, 2017
@alexcrichton
Rollup merge of rust-lang#44091 - kallisti5:haiku-fix, r=eddyb
f0ba1b9 
haiku/librustc_back: Remove incorrect no_integrated_as

* Makes rust bootstrap incorrectly search for xxx.s vs xxx.0.s
* Not needed or incorrect fix for another issue.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 26, 2017
@frewsxcv
Rollup merge of rust-lang#44091 - kallisti5:haiku-fix, r=eddyb
502a11d 
haiku/librustc_back: Remove incorrect no_integrated_as

* Makes rust bootstrap incorrectly search for xxx.s vs xxx.0.s
* Not needed or incorrect fix for another issue.
@frewsxcv frewsxcv mentioned this pull request Aug 26, 2017
Merged
bors added a commit that referenced this pull request Aug 26, 2017
@bors
Auto merge of #44098 - frewsxcv:rollup, r=frewsxcv
32f6056 
Rollup of 7 pull requests

- Successful merges: #43776, #43966, #43979, #44072, #44086, #44090, #44091
- Failed merges:
@bors bors merged commit 6ca124b into rust-lang:master Aug 26, 2017
@workingjubilee workingjubilee added the O-haiku Target: Be extant; from mouldering old leaves; spring arrives again label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
O-haiku Target: Be extant; from mouldering old leaves; spring arrives again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kallisti5 @rust-highfive @eddyb @bors @nikomatsakis @workingjubilee