Avoid hashing when creating a DepNode from a HirId #44335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, combine the already-present DefPathHash with the 32-bit ItemLocalIndex. Should fix rust-lang#44323.
|
See #44337 for worries about collision-resistance + combine. |
|
📌 Commit d14ed92 has been approved by |
arielb1
added
the
S-waiting-on-bors
|
Just wanted to add this to a rollup, but we are interested in the performance impact of this change, so it should stay a separate merge commit. Just in case anybody else gets a similar idea. |
|
@bors p=1 (perf improvement, hopefully) |
bors
added a commit
that referenced
this pull request
Sep 9, 2017
Avoid hashing when creating a DepNode from a HirId Instead, combine the already-present DefPathHash with the 32-bit ItemLocalIndex. Should fix #44323. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, combine the already-present DefPathHash with the 32-bit
ItemLocalIndex.
Should fix #44323.
r? @alexcrichton