-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend E0623 for earlybound and latebound for structs #44549
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @arielb1 |
test please |
// the lifetime of the TyPath! | ||
Some(rl::Region::LateBoundAnon(debruijn_index, anon_index)) => { | ||
(Some(rl::Region::LateBoundAnon(debruijn_index, anon_index)), ty::BrAnon(br_index)) => { | ||
if debruijn_index.depth == 1 && anon_index == br_index { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still doing the wrong thing with LBRs. Please compare against the correct deBruijn index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's #44516...right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not fixed by #44516, and is new code.
debug!("self.infcx.tcx.hir.local_def_id(id)={:?}", | ||
self.infcx.tcx.hir.local_def_id(id)); | ||
debug!("def_id={:?}", def_id); | ||
if debruijn_index.depth == 1 && self.infcx.tcx.hir.local_def_id(id) == def_id { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
ed6506d
to
696a268
Compare
@arielb1 updated |
I'm guessing this is complete. Let me know if anything more is needed @nikomatsakis @arielb1 |
@bors r+ |
📌 Commit 9240454 has been approved by |
Removing unwanted file merged in a previous commit
@arielb1 can you approve again |
@bors r+ |
📌 Commit 5229443 has been approved by |
@bors: rollup |
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
☔ The latest upstream changes (presumably #44654) made this pull request unmergeable. Please resolve the merge conflicts. |
This fixes #44508
r? @nikomatsakis