Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in codegen test #45089

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Fix typo in codegen test #45089

merged 1 commit into from
Oct 10, 2017

Conversation

hanna-kruppe
Copy link
Contributor

Without the :, the CHECK-NOT is ignored by FileCheck, making the line not test anything.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2017
@carols10cents
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @aturon or someone else from the team reviews it soon.

@carols10cents
Copy link
Member

Actually, @aturon is on PTO this week, so let's try....

r? @bluss

@rust-highfive rust-highfive assigned bluss and unassigned aturon Oct 9, 2017
@bluss
Copy link
Member

bluss commented Oct 9, 2017

@bors r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Oct 9, 2017

📌 Commit 7d1c14a has been approved by bluss

@kennytm kennytm mentioned this pull request Oct 10, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 10, 2017
@kennytm
Rollup merge of rust-lang#45089 - rkruppe:master, r=bluss
f2efa79 
Fix typo in codegen test

Without the `:`, the `CHECK-NOT` is ignored by FileCheck, making the line not test anything.
bors added a commit that referenced this pull request Oct 10, 2017
@bors
Auto merge of #45169 - kennytm:rollup, r=kennytm
d6d711d 
Rollup of 9 pull requests

- Successful merges: #44775, #45089, #45095, #45099, #45101, #45108, #45116, #45135, #45146
- Failed merges:
@bors bors merged commit 7d1c14a into rust-lang:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bluss bluss

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hanna-kruppe @rust-highfive @carols10cents @bluss @bors @aturon