Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: a LocalKey might start in the Valid state #45340

Merged
merged 1 commit into from Oct 18, 2017
Merged

Docs: a LocalKey might start in the Valid state #45340

merged 1 commit into from Oct 18, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2017

Add a comment to the docs for LocalKey::state explaining that some keys might skip the Uninitialized state and start in the Valid state.

cc #27716

r? @alexcrichton

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 17, 2017

📌 Commit a50fe31 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2017
@michaelwoerister
Copy link
Member

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2017
@kennytm
Rollup merge of rust-lang#45340 - stjepang:localkey-state-doc-skip-un…
c6892f4 
…initialized, r=alexcrichton

Docs: a LocalKey might start in the Valid state

Add a comment to the docs for `LocalKey::state` explaining that some keys might skip the `Uninitialized` state and start in the `Valid` state.

cc rust-lang#27716

r? @alexcrichton
@kennytm kennytm mentioned this pull request Oct 18, 2017
Merged
bors added a commit that referenced this pull request Oct 18, 2017
@bors
Auto merge of #45368 - kennytm:rollup, r=kennytm
b796087 
Rollup of 10 pull requests

- Successful merges: #44138, #45082, #45098, #45181, #45217, #45281, #45325, #45326, #45340, #45354
- Failed merges:
@alexcrichton alexcrichton merged commit a50fe31 into rust-lang:master Oct 18, 2017
@ghost ghost deleted the localkey-state-doc-skip-uninitialized branch October 18, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @bors @michaelwoerister @kennytm