Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Make Solaris builder compatible with Solaris 10 retry #45443

Merged
merged 2 commits into from
Oct 24, 2017
Merged

[beta] Make Solaris builder compatible with Solaris 10 retry #45443

merged 2 commits into from
Oct 24, 2017

Conversation

bgermann
Copy link
Contributor

@bgermann bgermann commented Oct 22, 2017 •
edited
Loading

Backport of #45343.

@bgermann
Make Solaris builder compatible with Solaris 10 retry
1dfc8d2 
Unfortunately, #45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.

(cherry picked from commit b3ea6e5)
@bgermann
Remove tabs
4c928f9 
(cherry picked from commit 0597bda)
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm
Copy link
Member

kennytm commented Oct 22, 2017

This is a backport of #45343, currently [beta-nominated].

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2017
@kennytm
Copy link
Member

kennytm commented Oct 23, 2017 •
edited
Loading

@bors r+

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2017
@bors
Copy link
Contributor

bors commented Oct 23, 2017

📌 Commit 4c928f9 has been approved by kennytm

@kennytm
Copy link
Member

kennytm commented Oct 23, 2017

@bors r+ retry

@bors
Copy link
Contributor

bors commented Oct 23, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Oct 23, 2017

📌 Commit 4c928f9 has been approved by kennytm

@bors
Copy link
Contributor

bors commented Oct 23, 2017

⌛ Testing commit 4c928f9 with merge c4008d6...

bors added a commit that referenced this pull request Oct 23, 2017
@bors
Auto merge of #45443 - bgermann:beta, r=kennytm
c4008d6 
[beta] Make Solaris builder compatible with Solaris 10 retry

Backport of #45343.
@bors
Copy link
Contributor

bors commented Oct 23, 2017

💔 Test failed - status-travis

@bgermann
Copy link
Contributor Author

Looks like a network issue.

@kennytm
Copy link
Member

kennytm commented Oct 24, 2017 •
edited
Loading

@bors retry

  1. The macOS check x86_64-apple-darwin job started 3 times
  2. On its third try, it failed to download rustc-1.21.0-x86_64-apple-darwin.tar.gz (hitting a "504 Gateway Time-out")

@bors
Copy link
Contributor

bors commented Oct 24, 2017

⌛ Testing commit 4c928f9 with merge f724781...

bors added a commit that referenced this pull request Oct 24, 2017
@bors
Auto merge of #45443 - bgermann:beta, r=kennytm
f724781 
[beta] Make Solaris builder compatible with Solaris 10 retry

Backport of #45343.
@bors
Copy link
Contributor

bors commented Oct 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing f724781 to beta...

@bors bors merged commit 4c928f9 into rust-lang:beta Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bgermann @rust-highfive @kennytm @bors @aturon