Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ci: Enable RUST_BACKTRACE=1 #45693

Closed
wants to merge 4 commits into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 1, 2017

  1. Enable RUST_BACKTRACE=1 when building (but not testing).
  2. Re-enable debug and LLVM assertions for macOS dist builds (they remain disabled in check builds).

WIP — checking if slowdown is within acceptable range (≤2 hours to complete).

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 1, 2017

For record:

Image master assertions no debug
x86_64-gnu-llvm-3.9 1h 16m 14s 1h 31m 44s 1h 10m 3s
check i686-apple-darwin 2h 40m 36s 2h 40m 56s 2h 50m 56s
dist i686-apple-darwin 1h 53m 43s 2h 34m 58s 2h 45m 49s
dist x86_64-apple-darwin 2h 20m 07s -- --
dist-s390x-linux 1h 39m 53s 1h 32m 49s 1h 41m 58s
x86_64-gnu-full-bootstrap 1h 06m 10s 1h 27m 48s 1h 08m 19s

Looks like the impact from debug/LLVM assertions are still huge, and enabling RUST_BACKTRACE=1 for Macs will push them very close to the 3 hr line.

Will try disable RUST_BACKTRACE=1 for macs entirely next.

@kennytm
Copy link
Member Author

kennytm commented Nov 5, 2017

Waiting for #45783. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant