Working towards a libc-less (wasm32) libstd #45725

alexcrichton · 2017-11-02T18:19:44Z

This is a series of commits I was able to extract from prepare to comiple libstd on a "bare libc-less" target, notably wasm32. The actual wasm32 bits I intend to send in a PR later, this is just some internal refactorings required for libstd to work with a libc that's empty and a few other assorted refactorings.

No functional change should be included in this PR for users of libstd, this is intended to just be internal refactorings.

rust-highfive · 2017-11-02T18:19:55Z

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

dtolnay · 2017-11-04T04:46:11Z

@bors r+

bors · 2017-11-04T04:46:12Z

📌 Commit db3d3f0 has been approved by dtolnay

LukasKalbertodt · 2017-11-04T17:58:45Z

What a lovely PR! All of the commits have long, great descriptions too 😮

bors · 2017-11-05T01:41:06Z

⌛ Testing commit db3d3f00233eb4442c653549c7534ebcc676e106 with merge f080a4046c5e9bb23da1c0a1bc519c551408ec82...

bors · 2017-11-05T01:45:56Z

💔 Test failed - status-appveyor

alexcrichton · 2017-11-05T03:18:20Z

@bors: r=dtolnay

bors · 2017-11-05T03:18:20Z

📌 Commit 5b673fe has been approved by dtolnay

alexcrichton · 2017-11-05T03:18:42Z

@bors: r=dtolnay

bors · 2017-11-05T03:18:42Z

📌 Commit e82ce58 has been approved by dtolnay

bors · 2017-11-05T06:34:40Z

⌛ Testing commit e82ce589e7f13106d87317f186b275969e17117a with merge 5c430c47d8be405885401082eec445dfe7419d8d...

bors · 2017-11-05T06:42:14Z

💔 Test failed - status-travis

kennytm · 2017-11-05T09:55:24Z

unused_import on macOS when building libstd.

[00:04:39] error: unused import: `self`
[00:04:39]   --> src/libstd/sys/unix/rand.rs:31:14
[00:04:39]    |
[00:04:39] 31 |     use io::{self, Read};
[00:04:39]    |              ^^^^
[00:04:39]    |
[00:04:39] note: lint level defined here
[00:04:39]   --> src/libstd/lib.rs:232:9
[00:04:39]    |
[00:04:39] 232| #![deny(warnings)]
[00:04:39]    |         ^^^^^^^^
[00:04:39]    = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[00:04:39] 
[00:04:43] error: aborting due to previous error
[00:04:43] 
[00:04:43] error: Could not compile `std`.

alexcrichton · 2017-11-05T16:02:40Z

@bors: r=dtolnay

bors · 2017-11-05T16:02:41Z

📌 Commit 847660c has been approved by dtolnay

bors · 2017-11-05T21:52:20Z

⌛ Testing commit 847660c3aeb2b81d3c836ee0cf0d93535c4cfdbc with merge de5fe8a8eca4f8bc459d7e48bd2497405b48fb37...

bors · 2017-11-05T22:06:13Z

💔 Test failed - status-travis

alexcrichton · 2017-11-06T02:59:15Z

@bors: r=dtolnay

bors · 2017-11-09T11:36:13Z

💔 Test failed - status-travis

bors · 2017-11-09T11:39:56Z

⌛ Testing commit 9435c71 with merge e811220421ad005f75424b01e78d7e1f88dbc39e...

bors · 2017-11-09T11:44:24Z

💔 Test failed - status-travis

bors · 2017-11-09T11:53:18Z

⌛ Testing commit 9435c71 with merge 9e989bf...

Working towards a libc-less (wasm32) libstd This is a series of commits I was able to extract from prepare to comiple libstd on a "bare libc-less" target, notably wasm32. The actual wasm32 bits I intend to send in a PR later, this is just some internal refactorings required for libstd to work with a `libc` that's empty and a few other assorted refactorings. No functional change should be included in this PR for users of libstd, this is intended to just be internal refactorings.

bors · 2017-11-09T11:56:10Z

💔 Test failed - status-travis

bors · 2017-11-09T13:25:27Z

⌛ Testing commit 9435c71 with merge be37f638ce7a40244220df291e0b5652ffc005fa...

bors · 2017-11-09T13:30:10Z

💔 Test failed - status-travis

alexcrichton · 2017-11-09T14:16:23Z

@bord: retry

alexcrichton · 2017-11-09T14:16:45Z

Er sorry

@bors: retry

kennytm · 2017-11-09T14:24:08Z

@bors treeclosed- p=0

bors · 2017-11-09T14:24:17Z

⌛ Testing commit 9435c71 with merge a5e95f7d2c5e1e2cee0b8b528e956a0ad992d1aa...

bors · 2017-11-09T15:42:24Z

💔 Test failed - status-travis

kennytm · 2017-11-09T15:56:43Z

Building stage2 std artifacts (x86_64-apple-darwin -> armv7-apple-ios)
...
[01:06:55] warning: dropping unsupported crate type `dylib` for target `armv7-apple-ios`
[01:06:55] 
[01:06:58] error[E0308]: mismatched types
[01:06:58]   --> src/libstd/sys/unix/backtrace/tracing/backtrace_fn.rs:39:29
[01:06:58]    |
[01:06:58] 39 |             exact_position: *from,
[01:06:58]    |                             ^^^^^ expected u8, found enum `libc::c_void`
[01:06:58]    |
[01:06:58]    = note: expected type `*const u8`
[01:06:58]               found type `*mut libc::c_void`
[01:06:58] 
[01:06:58] error[E0308]: mismatched types
[01:06:58]   --> src/libstd/sys/unix/backtrace/tracing/backtrace_fn.rs:40:26
[01:06:58]    |
[01:06:58] 40 |             symbol_addr: *from,
[01:06:58]    |                          ^^^^^ expected u8, found enum `libc::c_void`
[01:06:58]    |
[01:06:58]    = note: expected type `*const u8`
[01:06:58]               found type `*mut libc::c_void`

This commit removes usage of the `libc` crate in "portable" modules like those at the top level and `sys_common`. Instead common types like `*mut u8` or `u32` are used instead of `*mut c_void` or `c_int` as well as switching to platform-specific functions like `sys::strlen` instead of `libc::strlen`.

alexcrichton · 2017-11-09T15:57:04Z

@bors: r=dtolnay

bors · 2017-11-09T15:57:06Z

📌 Commit 5c3fe11 has been approved by dtolnay

bors · 2017-11-09T18:14:54Z

⌛ Testing commit 5c3fe11 with merge f1ea23e...

Working towards a libc-less (wasm32) libstd This is a series of commits I was able to extract from prepare to comiple libstd on a "bare libc-less" target, notably wasm32. The actual wasm32 bits I intend to send in a PR later, this is just some internal refactorings required for libstd to work with a `libc` that's empty and a few other assorted refactorings. No functional change should be included in this PR for users of libstd, this is intended to just be internal refactorings.

bors · 2017-11-09T20:46:36Z

☀️ Test successful - status-appveyor, status-travis
Approved by: dtolnay
Pushing f1ea23e to master...

bjorn3 · 2017-11-15T18:44:02Z

src/libstd/sys/redox/rand.rs

-use io;
-use rand::Rng;
-
-// FIXME: Use rand:


Please leave this FIXME

rust-highfive assigned dtolnay Nov 2, 2017

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2017

dtolnay approved these changes Nov 4, 2017

View reviewed changes

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2017

alexcrichton force-pushed the std-less-rand branch from 6ae7610 to 5b673fe Compare November 5, 2017 03:18

alexcrichton force-pushed the std-less-rand branch from 5b673fe to e82ce58 Compare November 5, 2017 03:18

alexcrichton force-pushed the std-less-rand branch from e82ce58 to 847660c Compare November 5, 2017 16:02

alexcrichton force-pushed the std-less-rand branch from 847660c to eae99f0 Compare November 6, 2017 02:59

alexcrichton force-pushed the std-less-rand branch from 9435c71 to 5c3fe11 Compare November 9, 2017 15:56

bors merged commit 5c3fe11 into rust-lang:master Nov 9, 2017

bors mentioned this pull request Nov 9, 2017

Ignore panic functions in backtraces. Print inlined functions on Windows #45637

Closed

bjorn3 reviewed Nov 15, 2017

View reviewed changes

src/libstd/sys/redox/rand.rs

use io;

use rand::Rng;

// FIXME: Use rand:

Copy link

Member

bjorn3 Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this FIXME

est31 mentioned this pull request Dec 1, 2017

Mismatched type error: type of crate instead of std is displayed #46112

Closed

alexcrichton deleted the std-less-rand branch December 1, 2017 21:26

Working towards a libc-less (wasm32) libstd #45725

Working towards a libc-less (wasm32) libstd #45725

Conversation

alexcrichton commented Nov 2, 2017

rust-highfive commented Nov 2, 2017

dtolnay commented Nov 4, 2017

bors commented Nov 4, 2017

LukasKalbertodt commented Nov 4, 2017

bors commented Nov 5, 2017

bors commented Nov 5, 2017

alexcrichton commented Nov 5, 2017

bors commented Nov 5, 2017

alexcrichton commented Nov 5, 2017

bors commented Nov 5, 2017

bors commented Nov 5, 2017

bors commented Nov 5, 2017

kennytm commented Nov 5, 2017

alexcrichton commented Nov 5, 2017

bors commented Nov 5, 2017

bors commented Nov 5, 2017

bors commented Nov 5, 2017

alexcrichton commented Nov 6, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

alexcrichton commented Nov 9, 2017

alexcrichton commented Nov 9, 2017

kennytm commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

kennytm commented Nov 9, 2017

alexcrichton commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bors commented Nov 9, 2017

bjorn3 Nov 15, 2017

Choose a reason for hiding this comment