Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all emission types in error msg if user inputs invalid option. #45782

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Nov 5, 2017

before:

> rustc --emit foo
error: unknown emission type: `foo`

after:

> rustc --emit foo
error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info`

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2017
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2017

📌 Commit 70787c3 has been approved by Manishearth

@Manishearth
Copy link
Member

@bors delegate+

@bors
Copy link
Contributor

bors commented Nov 7, 2017

✌️ @frewsxcv can now approve this pull request

before:

```
> rustc --emit foo
error: unknown emission type: `foo`
```

after:

```
> rustc --emit foo
error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info`
```
@frewsxcv frewsxcv force-pushed the frewsxcv-shorthands-helpers branch from 70787c3 to c3ea358 Compare November 7, 2017 01:37
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 7, 2017

@bors r=manishearth rollup

@bors
Copy link
Contributor

bors commented Nov 7, 2017

📌 Commit c3ea358 has been approved by manishearth

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2017
…s, r=manishearth

Display all emission types in error msg if user inputs invalid option.

before:

```
> rustc --emit foo
error: unknown emission type: `foo`
```

after:

```
> rustc --emit foo
error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info`
```
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2017
…s, r=manishearth

Display all emission types in error msg if user inputs invalid option.

before:

```
> rustc --emit foo
error: unknown emission type: `foo`
```

after:

```
> rustc --emit foo
error: unknown emission type: `foo` - expected one of: `llvm-bc`, `asm`, `llvm-ir`, `mir`, `obj`, `metadata`, `link`, `dep-info`
```
bors added a commit that referenced this pull request Nov 7, 2017
Rollup of 9 pull requests

- Successful merges: #45470, #45588, #45682, #45714, #45751, #45764, #45778, #45782, #45784
- Failed merges:
@bors bors merged commit c3ea358 into rust-lang:master Nov 7, 2017
@frewsxcv frewsxcv deleted the frewsxcv-shorthands-helpers branch January 7, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants