Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples in Cow::into_owned don't need to wrap result in Cows #45993

Merged
merged 1 commit into from
Nov 16, 2017
Merged

examples in Cow::into_owned don't need to wrap result in Cows #45993

merged 1 commit into from
Nov 16, 2017

Conversation

QuietMisdreavus
Copy link
Member

This totally confused me until i triple-checked the actual return value and opened the examples in the playground myself.

r? @rust-lang/docs

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2017
@kennytm
Copy link
Member

kennytm commented Nov 15, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 15, 2017

📌 Commit 479b919 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 16, 2017
@GuillaumeGomez
Rollup merge of rust-lang#45993 - QuietMisdreavus:anti-cow, r=kennytm
8debe61 
examples in Cow::into_owned don't need to wrap result in Cows

This totally confused me until i triple-checked the actual return value and opened the examples in the playground myself.

r? @rust-lang/docs
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 16, 2017
Merged
bors added a commit that referenced this pull request Nov 16, 2017
@bors
Auto merge of #46029 - GuillaumeGomez:rollup, r=GuillaumeGomez
58d8761 
Rollup of 6 pull requests

- Successful merges: #45951, #45973, #45984, #45993, #46005, #46010
- Failed merges:
@bors bors merged commit 479b919 into rust-lang:master Nov 16, 2017
@durka
Copy link
Contributor

durka commented Nov 17, 2017

How did these tests possibly pass before? 🤔 Are doctests not run or are these missing a fence?

@QuietMisdreavus
Copy link
Member Author

Cow<'a, str> impl's PartialEq with a bunch of different permutations of string type. If you ran the old examples, they totally compiled and ran perfectly fine, because the trait was there, and the equality matched up just fine.

@QuietMisdreavus QuietMisdreavus deleted the anti-cow branch May 9, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuietMisdreavus @kennytm @bors @durka