Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't glob-import overlapping variant names in test/codegen/match-optimizes-away.rs. #46078

Closed
wants to merge 1 commit into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Nov 18, 2017

The test added in #45821 wasn't really testing anything because of an overlap between glob imports of enum variants, so it was actually doing match x { y => y }, alongside triggering warnings.

@eddyb
Copy link
Member Author

eddyb commented Nov 18, 2017

r? @nikomatsakis

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2017

#[no_mangle]
pub fn three_valued(x: Three) -> Three {
// CHECK-LABEL: @three_valued
// CHECK-NEXT: {{^.*:$}}
// CHECK-NEXT: ret i8 %0
match x {
First => First,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, this is plain evil.
I'll make an issue for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nagisa
Copy link
Member

nagisa commented Nov 18, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2017

📌 Commit c3358a4 has been approved by nagisa

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2017
@kennytm
Copy link
Member

kennytm commented Nov 19, 2017

Note: If #45225 merged first this one can be closed since fb83283 is the same changeset.

@bors
Copy link
Contributor

bors commented Nov 19, 2017

⌛ Testing commit c3358a4 with merge 270fd731c1acf82ff4edfcb228cbaffce4758fdb...

@eddyb
Copy link
Member Author

eddyb commented Nov 19, 2017

@bors retry (make way for #45225)

@eddyb eddyb closed this Nov 20, 2017
@eddyb eddyb deleted the revenge-of-the-globs branch November 20, 2017 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants