Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean the Debug impl for CrateNum and DefId #46120

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 20, 2017

Just a tiny quality-of-life improvement because I got tired of noisy debug logs.

before: DefId { krate: CrateNum(11), index: DefIndex(0:6) => foo[8787]::Mapper[0]::OtherType[0] } }
after: {crate11:0:6 ~ foo[8787]::Mapper[0]::OtherType[0]})

r? @michaelwoerister

@arielb1
Copy link
Contributor Author

arielb1 commented Nov 20, 2017

@bors rollup

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2017
@kennytm
Copy link
Member

kennytm commented Nov 20, 2017

The mir-opt tests need to be updated for the new representation.

[00:56:38] failures:
[00:56:38]     [mir-opt] mir-opt/validate_1.rs
[00:56:38]     [mir-opt] mir-opt/validate_4.rs
[00:56:38]     [mir-opt] mir-opt/validate_5.rs

@michaelwoerister
Copy link
Member

I like the idea. I think the concrete format could be improved though. In particular crate11:0:6 is a bit confusing. I'd either like it more concise:

after: {11.0.6 ~ foo[8787]::Mapper[0]::OtherType[0]})

Or a bit more self-explanatory:

after: {DefId(11/0:6) ~ foo[8787]::Mapper[0]::OtherType[0]}

before: DefId { krate: CrateNum(11), index: DefIndex(0:6) => foo[8787]::Mapper[0]::OtherType[0] } }
after: DefId(11:0:6 ~ foo[8787]::Mapper[0]::OtherType[0])
@michaelwoerister
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 21, 2017

📌 Commit e7c8fbf has been approved by michaelwoerister

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 21, 2017
clean the Debug impl for CrateNum and DefId

Just a tiny quality-of-life improvement because I got tired of noisy debug logs.

```
before: DefId { krate: CrateNum(11), index: DefIndex(0:6) => foo[8787]::Mapper[0]::OtherType[0] } }
after: {crate11:0:6 ~ foo[8787]::Mapper[0]::OtherType[0]})
```

r? @michaelwoerister
bors added a commit that referenced this pull request Nov 21, 2017
Rollup of 11 pull requests

- Successful merges: #45987, #46031, #46050, #46052, #46103, #46120, #46134, #46141, #46148, #46155, #46157
- Failed merges:
@bors bors merged commit e7c8fbf into rust-lang:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants